feat(dynamic_value): Refactor IAM member resource iteration method#442
Merged
Conversation
Umm-E-Kulsum
requested review from
a team,
ayushmjain,
krprabhat-eng and
q2w
as code owners
Contributor
Author
|
krprabhat-eng
approved these changes
Jan 22, 2026
|
This is a breaking change, look at this kubernetes/k8s.io#9169 (comment) Please revert this and issue a new release |
|
Why was this change implemented? It's both a breaking change, and an anti-pattern, making changes more fragile by keying on an arbitrary index instead of on the role and member. If the breaking change was intentional, then the major version number not incremented, which breaks semantic versioning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.