fix(cli): Avoid printing the cli help text during shell completion #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @garbelini Thanks for the contribution! We are going to automate the CLA (Contributor License Agreement) process and get back to you in a few days. Sorry for the delay. |
|
@i4ki That's great. Thanks for the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Autocomplete is handled by kongplete and due to a workaround in the code to avoid errors when
terramate --versioncoupled with defaulting to adding--helpto the arguments if they are empty we end up on a state where the help will always be printed during autocomplete.To avoid coming up with yet another workaround or changing the current behavior of printing help on argument parsing errors, I felt the best option would be to exit as soon as the completion is done.
Which issue(s) this PR fixes:
Fixes #1739
Special notes for your reviewer:
I couldn't find a good location for tests or even if it would be necessary in this case. Just let me know if needed and I can see if I can find a way to test this.
Does this PR introduce a user-facing change?
no