Skip to content

Commit

Permalink
Responding to comments
Browse files Browse the repository at this point in the history
  • Loading branch information
john-science committed Nov 21, 2023
1 parent 7403f4b commit 7c42d47
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
10 changes: 10 additions & 0 deletions armi/nucDirectory/tests/test_elements.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ def test_element_isNaturallyOccurring(self):
Uses RIPL definitions of naturally occurring. Protactinium is debated as naturally
occurring. Yeah it exists as a U235 decay product but it's kind of pseudo-natural.
.. test:: Get elements by Z, to show if they are naturally occurring.
:id: I_ARMI_ND_ELEMENTS3
:tests: R_ARMI_ND_ELEMENTS
"""
for ee in elements.byZ.values():
if ee.z == 43 or ee.z == 61 or 84 <= ee.z <= 89 or ee.z >= 93:
Expand All @@ -122,6 +126,12 @@ def test_abundancesAddToOne(self):
)

def test_isHeavyMetal(self):
"""Get elements by Z.
.. test:: Get elements by Z, to show if they are heavy metals.
:id: I_ARMI_ND_ELEMENTS4
:tests: R_ARMI_ND_ELEMENTS
"""
for ee in elements.byZ.values():
if ee.z > 89:
self.assertTrue(ee.isHeavyMetal())
Expand Down
2 changes: 1 addition & 1 deletion armi/nucDirectory/tests/test_nuclideBases.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ def test_nucBases_imposeBurnChainTransmutationBulkStatistics(self):
def test_nucBases_imposeBurn_nuSF(self):
"""Test the natural abundance values.
.. test:: Test the natural abundance that was read from file instead of code.
.. test:: Test that nuclide data was read from file instead of code.
:id: I_ARMI_ND_DATA0
:tests: R_ARMI_ND_DATA
"""
Expand Down

0 comments on commit 7c42d47

Please sign in to comment.