Responding to comments

terrapower · Nov 22, 2023 · 8adfd23 · 8adfd23
1 parent a96f0a5
commit 8adfd23
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/armi/reactor/components/component.py b/armi/reactor/components/component.py
@@ -173,6 +173,10 @@ class Component(composites.Composite, metaclass=ComponentType):
         :id: I_ARMI_COMP_DEF
         :implements: R_ARMI_COMP_DEF
 
+        .. impl:: Order components by there outermost diameter (using the < operator).
+            :id: I_ARMI_COMP_ORDER
+            :implements: R_ARMI_COMP_ORDER
+
     Attributes
     ----------
     temperatureInC : float
@@ -256,10 +260,6 @@ def __lt__(self, other):
         True if a circle encompassing this object has a smaller diameter than one encompassing another component.
 
         This allows sorting because the Python sort functions only use this method.
-
-        .. impl:: Order components by there outermost diameter.
-            :id: I_ARMI_COMP_ORDER
-            :implements: R_ARMI_COMP_ORDER
         """
         thisOD = self.getBoundingCircleOuterDiameter(cold=True)
         thatOD = other.getBoundingCircleOuterDiameter(cold=True)

diff --git a/armi/reactor/tests/test_composites.py b/armi/reactor/tests/test_composites.py
@@ -113,11 +113,11 @@ def setUp(self):
     def test_composite(self):
         """Test basic Composite things.
 
-        .. test:: Components are a physical part of the reactor.
+        .. test:: Composites are a physical part of the reactor.
             :id: T_ARMI_CMP0
             :tests: R_ARMI_CMP
 
-        .. test:: Components are part of a hierarchical model.
+        .. test:: Composites are part of a hierarchical model.
             :id: T_ARMI_CMP_CHILDREN0
             :tests: R_ARMI_CMP_CHILDREN
         """
@@ -136,11 +136,11 @@ def test_iterComponents(self):
     def test_getChildren(self):
         """Test the get children method.
 
-        .. test:: Components are a physical part of the reactor.
+        .. test:: Composites are a physical part of the reactor.
             :id: T_ARMI_CMP1
             :tests: R_ARMI_CMP
 
-        .. test:: Components are part of a hierarchical model.
+        .. test:: Composites are part of a hierarchical model.
             :id: T_ARMI_CMP_CHILDREN1
             :tests: R_ARMI_CMP_CHILDREN
         """

diff --git a/armi/reactor/tests/test_reactors.py b/armi/reactor/tests/test_reactors.py
@@ -246,8 +246,12 @@ def test_coreSfp(self):
             :tests: R_ARMI_R
 
         .. test:: The reactor object includes a core and an SFP.
-            :id: T_ARMI_R_CHILDREN
+            :id: T_ARMI_R_CHILDREN1
             :tests: R_ARMI_R_CHILDREN
+
+        .. test:: Components are a physical part of the reactor.
+            :id: T_ARMI_CMP2
+            :tests: R_ARMI_CMP
         """
         self.assertTrue(isinstance(self.r.core, reactors.Core))
         self.assertTrue(isinstance(self.r.sfp, SpentFuelPool))