Skip to content

Commit

Permalink
Fixing test class names
Browse files Browse the repository at this point in the history
  • Loading branch information
john-science committed Nov 28, 2023
1 parent 42dc471 commit 8b2c332
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions armi/settings/tests/test_settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
THIS_DIR = os.path.dirname(__file__)


class DummyParamPlugin1(plugins.ArmiPlugin):
class DummySettingPlugin1(plugins.ArmiPlugin):
@staticmethod
@plugins.HOOKIMPL
def defineSettings():
Expand All @@ -58,7 +58,7 @@ def defineSettings():
]


class DummyParamPlugin2(plugins.ArmiPlugin):
class DummySettingPlugin2(plugins.ArmiPlugin):
@staticmethod
@plugins.HOOKIMPL
def defineSettings():
Expand Down Expand Up @@ -241,7 +241,7 @@ def test_pluginSettings(self):
:tests: R_ARMI_PLUGIN_SETTINGS
"""
pm = getPluginManagerOrFail()
pm.register(DummyParamPlugin1)
pm.register(DummySettingPlugin1)
# We have a setting; this should be fine
cs = caseSettings.Settings()

Expand All @@ -252,20 +252,20 @@ def test_pluginSettings(self):
newSettings = {"extendableOption": "PLUGIN"}
cs = cs.modified(newSettings=newSettings)

pm.register(DummyParamPlugin2)
pm.register(DummySettingPlugin2)
cs = caseSettings.Settings()
self.assertEqual(cs["extendableOption"], "PLUGIN")
# Now we should have the option from plugin 2; make sure that works
cs = cs.modified(newSettings=newSettings)
cs["extendableOption"] = "PLUGIN"
self.assertIn("extendableOption", cs.keys())
pm.unregister(DummyParamPlugin2)
pm.unregister(DummyParamPlugin1)
pm.unregister(DummySettingPlugin2)
pm.unregister(DummySettingPlugin1)

# Now try the same, but adding the plugins in a different order. This is to make
# sure that it doesnt matter if the Setting or its Options come first
pm.register(DummyParamPlugin2)
pm.register(DummyParamPlugin1)
pm.register(DummySettingPlugin2)
pm.register(DummySettingPlugin1)
cs = caseSettings.Settings()
self.assertEqual(cs["extendableOption"], "PLUGIN")

Expand Down

0 comments on commit 8b2c332

Please sign in to comment.