Skip to content

Commit

Permalink
Responding to comments
Browse files Browse the repository at this point in the history
  • Loading branch information
john-science committed Nov 27, 2023
1 parent 2cb0853 commit 9f94cb5
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 19 deletions.
21 changes: 11 additions & 10 deletions armi/materials/tests/test_materials.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,7 @@ def test_TD(self):
self.assertEqual(self.mat.cached, {})

def test_duplicate(self):
"""Test the material duplication.
.. test:: Test the material base class.
:id: T_ARMI_MAT_PROPERTIES3
:tests: R_ARMI_MAT_PROPERTIES
.. test:: Materials shall calc mass fracs at init.
:id: T_ARMI_MAT_FRACS
:tests: R_ARMI_MAT_FRACS
"""
"""Test the material duplication."""
mat = self.mat.duplicate()

self.assertEqual(len(mat.massFrac), len(self.mat.massFrac))
Expand Down Expand Up @@ -725,6 +716,16 @@ def test_getTempChangeForDensityChange(self):
self.assertAlmostEqual(expectedDeltaT, actualDeltaT)

def test_duplicate(self):
"""Test the material duplication.
.. test:: Test the material base class is usable.
:id: T_ARMI_MAT_PROPERTIES3
:tests: R_ARMI_MAT_PROPERTIES
.. test:: Materials shall calc mass fracs at init.
:id: T_ARMI_MAT_FRACS
:tests: R_ARMI_MAT_FRACS
"""
duplicateU = self.mat.duplicate()

for key in self.mat.massFrac:
Expand Down
4 changes: 0 additions & 4 deletions armi/reactor/components/component.py
Original file line number Diff line number Diff line change
Expand Up @@ -260,10 +260,6 @@ def __lt__(self, other):
True if a circle encompassing this object has a smaller diameter than one encompassing another component.
This allows sorting because the Python sort functions only use this method.
.. impl:: Order components by there outermost diameter.
:id: I_ARMI_COMP_ORDER
:implements: R_ARMI_COMP_ORDER
"""
thisOD = self.getBoundingCircleOuterDiameter(cold=True)
thatOD = other.getBoundingCircleOuterDiameter(cold=True)
Expand Down
6 changes: 1 addition & 5 deletions armi/reactor/composites.py
Original file line number Diff line number Diff line change
Expand Up @@ -672,11 +672,7 @@ def hasFlags(self, typeID: TypeSpec, exact=False):
"""
Determine if this object is of a certain type.
.. impl:: Flags can be queried.
:id: I_ARMI_CMP_FLAG
:implements: R_ARMI_CMP_FLAG
.. impl:: Composites have flags
.. impl:: Composites have queriable flags.
:id: I_ARMI_CMP_FLAG
:implements: R_ARMI_CMP_FLAG
Expand Down

0 comments on commit 9f94cb5

Please sign in to comment.