Skip to content

Commit

Permalink
Fixing merge resolution errors/linting typo fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
bdlafleur committed Nov 21, 2023
1 parent 0bce138 commit f696fbe
Show file tree
Hide file tree
Showing 14 changed files with 11 additions and 57 deletions.
1 change: 0 additions & 1 deletion armi/cases/suite.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ class CaseSuite:
A CaseSuite is a collection that is keyed off Case titles.
.. impl:: Dependence allows for one case to start after the completion of another
:id: I_ARMI_CASE_SUITE
:implements: R_ARMI_CASE_SUITE
Expand Down
7 changes: 1 addition & 6 deletions armi/nuclearDataIO/cccc/dif3d.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,7 @@ def __init__(self):


class Dif3dStream(cccc.StreamWithDataContainer):
"""Tool to read and write DIF3D files.
.. impl:: Tool to read and write DIF3D files.
:id: I_ARMI_NUCDATA_DIF3D
:implements: R_ARMI_NUCDATA_DIF3D
"""
"""Tool to read and write DIF3D files."""

@staticmethod
def _getDataContainer() -> Dif3dData:
Expand Down
4 changes: 0 additions & 4 deletions armi/nuclearDataIO/cccc/dlayxs.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,6 @@ class Dlayxs(collections.OrderedDict):
If you want an average over all nuclides, then you need to produce it using the properly-computed
average contributions of each nuclide.
.. impl:: Tool to read and write DLAYXS files.
:id: I_ARMI_NUCDATA_DLAYXS
:implements: R_ARMI_NUCDATA_DLAYXS
Attributes
----------
nuclideFamily : dict
Expand Down
8 changes: 2 additions & 6 deletions armi/nuclearDataIO/cccc/gamiso.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
:id: I_ARMI_NUCDATA_GAMISO
:implements: R_ARMI_NUCDATA_GAMISO
See [GAMSOR]_.
See [GAMSOR]_.
.. [GAMSOR] Smith, M. A., Lee, C. H., and Hill, R. N. GAMSOR: Gamma Source Preparation and DIF3D Flux Solution. United States:
.. [GAMSOR] Smith, M. A., Lee, C. H., and Hill, R. N. GAMSOR: Gamma Source Preparation and DIF3D Flux Solution. United States:
N. p., 2016. Web. doi:10.2172/1343095. `On OSTI <https://www.osti.gov/biblio/1343095-gamsor-gamma-source-preparation-dif3d-flux-solution>`_
"""

Expand Down Expand Up @@ -118,10 +118,6 @@ class _GamisoIO(isotxs.IsotxsIO):
"""
A reader/writer for GAMISO data files.
.. impl:: Tool to read and write GAMISO files.
:id: I_ARMI_NUCDATA_GAMISO
:implements: R_ARMI_NUCDATA_GAMISO
Notes
-----
The GAMISO file format is identical to ISOTXS.
Expand Down
4 changes: 0 additions & 4 deletions armi/nuclearDataIO/cccc/geodst.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,6 @@ class GeodstStream(cccc.StreamWithDataContainer):
"""
Stream for reading to/writing from with GEODST data.
.. impl:: Tool to read and write GEODST files.
:id: I_ARMI_NUCDATA_GEODST
:implements: R_ARMI_NUCDATA_GEODST
Parameters
----------
geom : GeodstData
Expand Down
6 changes: 1 addition & 5 deletions armi/nuclearDataIO/cccc/isotxs.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
ISOTXS is a binary file that contains multigroup microscopic cross sections.
ISOTXS stands for *Isotope Cross Sections*.
ISOTXS files are often created by a lattice physics code such as MC2 or DRAGON and
ISOTXS files are often created by a lattice physics code such as MC2 or DRAGON and
used as input to a global flux solver such as DIF3D.
This module implements reading and writing of the
Expand Down Expand Up @@ -191,10 +191,6 @@ class IsotxsIO(cccc.Stream):
"""
A semi-abstract stream for reading and writing to a :py:class:`~armi.nuclearDataIO.isotxs.Isotxs`.
.. impl:: Tool to read and write ISOTXS files.
:id: I_ARMI_NUCDATA_ISOTXS
:implements: R_ARMI_NUCDATA_ISOTXS
Notes
-----
This is a bit of a special case compared to most other CCCC files because of the special
Expand Down
7 changes: 0 additions & 7 deletions armi/nuclearDataIO/cccc/pmatrx.py
Original file line number Diff line number Diff line change
Expand Up @@ -168,13 +168,6 @@ def _readWrite(lib, fileName, fileMode, getNuclideFunc):


class PmatrxIO(cccc.Stream):
"""Tool to read and write PMATRX files.
.. impl:: Tool to read and write PMATRX files.
:id: I_ARMI_NUCDATA_PMATRX
:implements: R_ARMI_NUCDATA_PMATRX
"""

def __init__(self, fileName, xsLib, fileMode, getNuclideFunc):
cccc.Stream.__init__(self, fileName, fileMode)
self._lib = xsLib
Expand Down
6 changes: 0 additions & 6 deletions armi/nuclearDataIO/cccc/tests/test_gamiso.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,6 @@ def setUp(self):
def test_compare(self):
"""Compare the input binary GAMISO file.
.. test:: Test reading GAMISO files.
:id: T_ARMI_NUCDATA_GAMISO
:tests: R_ARMI_NUCDATA_GAMISO
"""
"""Compare the input binary GAMISO file.
.. test:: Test reading GAMISO files.
:id: T_ARMI_NUCDATA_GAMISO0
:tests: R_ARMI_NUCDATA_GAMISO
Expand Down
4 changes: 2 additions & 2 deletions armi/operators/operator.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class Operator:
:id: I_ARMI_OPERATOR_COMM
:implements: R_ARMI_OPERATOR_COMM
.. impl:: An operator is build from user settings.
.. impl:: An operator is built from user settings.
:id: I_ARMI_OPERATOR_SETTINGS
:implements: R_ARMI_OPERATOR_SETTINGS
Expand Down Expand Up @@ -402,7 +402,7 @@ def _timeNodeLoop(self, cycle, timeNode):
def _performTightCoupling(self, cycle: int, timeNode: int, writeDB: bool = True):
"""If requested, perform tight coupling and write out database.
.. impl:: The operator shall allow coupling between physics systems.
.. impl:: The operator shall allow tight coupling between physics systems.
:id: I_ARMI_OPERATOR_PHYSICS
:implements: R_ARMI_OPERATOR_PHYSICS
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,7 @@ def test_calcReactionRates(self):
.. test:: Return the reaction rates for a given ArmiObject
:id: T_ARMI_FLUX_RX_RATES
:tests: R_ARMI_FLUX_RX_RATES
.. warning: This does not validate the reaction rate calculation.
"""
b = test_blocks.loadTestBlock()
Expand Down
14 changes: 1 addition & 13 deletions armi/plugins.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,7 @@ class ArmiPlugin:
An ArmiPlugin provides a namespace to collect hook implementations provided by a
single "plugin". This API is incomplete, unstable, and expected to change.
.. impl:: Plugins have interfaces, to add code to the application.
:id: I_ARMI_PLUGIN
:implements: R_ARMI_PLUGIN
.. impl:: Plugins have interfaces, to add code to the application.
.. impl:: Plugins have interfaces to add code to the application.
:id: I_ARMI_PLUGIN
:implements: R_ARMI_PLUGIN
"""
Expand All @@ -156,14 +152,6 @@ def exposeInterfaces(cs) -> List:
"""
Function for exposing interface(s) to other code.
.. impl:: Plugins have interfaces to the operator.
:id: I_ARMI_PLUGIN_INTERFACES
:implements: R_ARMI_PLUGIN_INTERFACES
.. impl:: Define an arbitrary physical parameter.
:id: I_ARMI_PARAM
:implements: R_ARMI_PARAM
.. impl:: Plugins have interfaces to the operator.
:id: I_ARMI_PLUGIN_INTERFACES
:implements: R_ARMI_PLUGIN_INTERFACES
Expand Down
2 changes: 1 addition & 1 deletion armi/reactor/components/component.py
Original file line number Diff line number Diff line change
Expand Up @@ -1177,7 +1177,7 @@ def getIntegratedMgFlux(self, adjoint=False, gamma=False):
def density(self):
"""Returns the mass density of the object in g/cc.
.. impl:: Material densitiy is retrievable
.. impl:: Material density is retrievable
:id: I_ARMI_COMP_MAT1
:implements: R_ARMI_COMP_MAT
"""
Expand Down
2 changes: 1 addition & 1 deletion armi/reactor/parameters/parameterDefinitions.py
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ def __get__(self, obj, cls=None):
def setter(self, setter):
"""Decorator method for assigning setter.
.. impl:: Provide a way to signal if a parameter needs updated across processes.
.. impl:: Provide a way to signal if a parameter needs updating across processes.
:id: I_ARMI_PARAM_PARALLEL
:implements: R_ARMI_PARAM_PARALLEL
Expand Down
2 changes: 1 addition & 1 deletion armi/reactor/tests/test_components.py
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ def test_volumeAfterClearCache(self):
"""
Test volume after cache has been cleared.
.. test:: Clear cache after a dimenions updated
.. test:: Clear cache after a dimensions updated
:id: T_ARMI_COMP_VOL1
:tests: R_ARMI_COMP_VOL
"""
Expand Down

0 comments on commit f696fbe

Please sign in to comment.