Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating runLog requirement crumbs #1517

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

john-science
Copy link
Member

What is the change?

Here I make some updates to runLog requirement crumbs:

  • remove some faulty req crumbs from the material package (typos?)
  • Add more req crumbs
  • Beef up some runLog tests

Why is the change being made?

This is in response to requirement review by @jakehader


Checklist

  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • No requirements were altered.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added documentation Improvements or additions to documentation testing Related to tests labels Dec 5, 2023
@john-science
Copy link
Member Author

@keckler @albeanth This is my attempt at completing a review-response cycle.

Along with this, I figure I have to talk to Jake and get his sign-off.

Tell me if you think this does/doesn't meet our needs.

@albeanth
Copy link
Member

albeanth commented Dec 8, 2023

I'm not familiar with the specifics that were requested by Jake but I think the changes look fine to me. 👍

@john-science john-science merged commit 4a4d832 into main Dec 8, 2023
25 checks passed
@john-science john-science deleted the reviewing_runlog_reqs branch December 8, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation testing Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants