Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a test and crumbs for defining flags #1521

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Conversation

john-science
Copy link
Member

What is the change?

Adding a test and crumbs for defining flags.

Why is the change being made?

This is in response to requirement review by @keckler


Checklist

  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • No requirements were altered.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added documentation Improvements or additions to documentation testing Related to tests labels Dec 6, 2023
@john-science john-science requested a review from keckler December 6, 2023 21:41
@john-science
Copy link
Member Author

@keckler Also, bonus, I removed a defunct comment from test_energyGroups.py.

Copy link
Member

@keckler keckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great unit test!

armi/plugins.py Outdated Show resolved Hide resolved
Co-authored-by: Chris Keckler <[email protected]>
@john-science john-science merged commit 8b9873c into main Dec 7, 2023
21 checks passed
@john-science john-science deleted the define_flags_crumbs branch December 7, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation testing Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants