Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving block tests and test crumbs #1526

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Improving block tests and test crumbs #1526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fedfc55
Fixing broken test crumb
john-science Dec 7, 2023
da7f686
Improving hex area test
john-science Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion armi/physics/neutronics/tests/test_macroXSGenerationInterface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class TestMacroXSGenerationInterface(unittest.TestCase):
def test_macroXSGenerationInterfaceBasics(self):
"""Test the macroscopic XS generating interfaces.

.. test::Build macroscopic cross sections for all blocks in the reactor.
.. test:: Build macroscopic cross sections for all blocks in the reactor.
:id: T_ARMI_MACRO_XS
:tests: R_ARMI_MACRO_XS
"""
Expand Down
34 changes: 28 additions & 6 deletions armi/reactor/tests/test_blocks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1842,17 +1842,39 @@ def setUp(self):
r.core.add(a, loc1)

def test_getArea(self):
cur = self.HexBlock.getArea()
ref = math.sqrt(3) / 2.0 * 70.6**2
places = 6
self.assertAlmostEqual(cur, ref, places=places)
"""Test that we can correctly calculate the area of a hexagonal block.

.. test:: Users can create blocks that have the correct hexagonal area.
:id: T_ARMI_BLOCK_HEX0
:tests: R_ARMI_BLOCK_HEX
"""
# Test for various outer and inner pitches for HexBlocks with hex holes
for op in (20.0, 20.4, 20.1234, 25.001):
for ip in (0.0, 5.0001, 7.123, 10.0):
# generate a block with a different outer pitch
hBlock = blocks.HexBlock("TestAreaHexBlock")
hexDims = {
"Tinput": 273.0,
"Thot": 273.0,
"op": op,
"ip": ip,
"mult": 1.0,
}
hComponent = components.Hexagon("duct", "UZr", **hexDims)
hBlock.add(hComponent)

# verify the area of the hexagon (with a hex hole) is correct
cur = hBlock.getArea()
ref = math.sqrt(3) / 2.0 * op**2
ref -= math.sqrt(3) / 2.0 * ip**2
self.assertAlmostEqual(cur, ref, places=6, msg=str(op))

def test_component_type(self):
"""
Test that a hex block has the proper "hexagon" __name__.

.. test:: Users can create hex shaped blocks.
:id: T_ARMI_BLOCK_HEX
.. test:: Users can create blocks with a hexagonal shape.
:id: T_ARMI_BLOCK_HEX1
:tests: R_ARMI_BLOCK_HEX
"""
pitch_comp_type = self.HexBlock.PITCH_COMPONENT_TYPE[0]
Expand Down
Loading