Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop checking for last node in Snapshots #2035

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

onufer
Copy link
Member

@onufer onufer commented Dec 13, 2024

What is the change?

Stop checking if its the last node since this often breaks for snapshots and just calculate reactivity swing at all nodes.

Why is the change being made?

If you do snapshot and don't have cycles and nodes consistent, you get an error.

Cycles and nodes don't have meaning for snapshots, so it is probably best to not force this and calculate partial cycle reactivity swing.

see #2034

SCR Information

Change Type: features

One-Sentence Description: Stop checking if its the last node since this often breaks for snapshots and just calculate reactivity swing at all nodes.

One-line Impact on Requirements: NA


Checklist

@onufer onufer requested a review from mgjarrett December 13, 2024 20:21
@john-science john-science added the feature request Smaller user request label Mar 14, 2025
@john-science john-science changed the title reactivity swing Stop checking for last node in Snapshots Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Smaller user request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants