Stop checking for last node in Snapshots #2035
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
Stop checking if its the last node since this often breaks for snapshots and just calculate reactivity swing at all nodes.
Why is the change being made?
If you do snapshot and don't have cycles and nodes consistent, you get an error.
Cycles and nodes don't have meaning for snapshots, so it is probably best to not force this and calculate partial cycle reactivity swing.
see #2034
SCR Information
Change Type: features
One-Sentence Description: Stop checking if its the last node since this often breaks for snapshots and just calculate reactivity swing at all nodes.
One-line Impact on Requirements: NA
Checklist
doc
folder.pyproject.toml
.