Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand allowable XS types to include lower case letters #2069

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion armi/physics/neutronics/crossSectionGroupManager.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def describeInterfaces(cs):
return None


_ALLOWABLE_XS_TYPE_LIST = list(string.ascii_uppercase)
_ALLOWABLE_XS_TYPE_LIST = list(string.ascii_uppercase + string.ascii_lowercase)


def getXSTypeNumberFromLabel(xsTypeLabel: str) -> int:
Expand Down
7 changes: 7 additions & 0 deletions armi/physics/neutronics/tests/test_crossSectionManager.py
Original file line number Diff line number Diff line change
Expand Up @@ -868,6 +868,13 @@ def test_getNextAvailableXsType(self):
self.assertEqual("C", xsType2)
self.assertEqual("D", xsType3)

# verify that we can get lowercase letters
xsTypes = self.csm.getNextAvailableXsTypes(27)
self.assertEqual("Y", xsTypes[-4])
self.assertEqual("a", xsTypes[-3])
self.assertEqual("b", xsTypes[-2])
self.assertEqual("c", xsTypes[-1])

def test_getRepresentativeBlocks(self):
"""Test that we can create the representative blocks for a reactor.

Expand Down