-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix application of custom isotopics to work with Fluid classes #2071
Conversation
While this has a unit test, I am running some cases offline to be extra sure. |
Okay, pretty sure this is ready to go. Let me know if there are any questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think these changes fall under what is currently documented so no additional documentation is necessary.
Have you run downstream tests for this repo? (Expect me to ask that question for all your current bug fix PRs today. lawls) |
I think this should have a release note under "Bug Fixes". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Could use a release note.
Yes I have. I came upon this bug because I was playing around with our model of JOYO and was getting some incorrect answers. After this PR, the model appears to be working appropriately, and the predictions line up very well with experiment. |
Co-authored-by: John Stilley <[email protected]>
Done! |
What is the change?
There was a bug in components that combined custom isotopics with material classes that are instances of
Fluid
. In those cases, the density was not being adjusted fromTinput
->Thot
when the component was initialized.See #2070 for more details.
Why is the change being made?
Fix a bug (#2070 )
Checklist
doc
folder.pyproject.toml
.