Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application of custom isotopics to work with Fluid classes #2071

Merged
merged 6 commits into from
Feb 4, 2025

Conversation

keckler
Copy link
Member

@keckler keckler commented Feb 2, 2025

What is the change?

There was a bug in components that combined custom isotopics with material classes that are instances of Fluid. In those cases, the density was not being adjusted from Tinput -> Thot when the component was initialized.

See #2070 for more details.

Why is the change being made?

Fix a bug (#2070 )


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@keckler
Copy link
Member Author

keckler commented Feb 2, 2025

While this has a unit test, I am running some cases offline to be extra sure.

@keckler keckler linked an issue Feb 2, 2025 that may be closed by this pull request
@keckler
Copy link
Member Author

keckler commented Feb 2, 2025

Okay, pretty sure this is ready to go. Let me know if there are any questions.

@keckler keckler marked this pull request as ready for review February 2, 2025 21:11
Copy link
Contributor

@bsculac bsculac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think these changes fall under what is currently documented so no additional documentation is necessary.

@john-science john-science added the bug Something is wrong: Highest Priority label Feb 3, 2025
@john-science
Copy link
Member

Have you run downstream tests for this repo? (Expect me to ask that question for all your current bug fix PRs today. lawls)

@john-science
Copy link
Member

I think this should have a release note under "Bug Fixes".

Copy link
Member

@john-science john-science left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Could use a release note.

@keckler
Copy link
Member Author

keckler commented Feb 3, 2025

Have you run downstream tests for this repo? (Expect me to ask that question for all your current bug fix PRs today. lawls)

Yes I have. I came upon this bug because I was playing around with our model of JOYO and was getting some incorrect answers. After this PR, the model appears to be working appropriately, and the predictions line up very well with experiment.

@keckler
Copy link
Member Author

keckler commented Feb 3, 2025

Looks good.

Could use a release note.

Done!

@john-science john-science merged commit 4c71773 into main Feb 4, 2025
22 checks passed
@john-science john-science deleted the customIsotopicsFluid branch February 4, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when custom isotopics are combined with material classes
3 participants