Skip to content

Conversation

@john-science
Copy link
Member

@john-science john-science commented Jul 9, 2025

What is the change? Why is it being made?

The name function in Interface.function clashes heavily with the Python reserved word "function". It is also just not a very helpful name, as it could mean almost anything.

close #2125

SCR Information

Change Type: trivial

One-Sentence Description: Changing Interface.function to Interface.purpose.

One-line Impact on Requirements: Minor edit to the implementation I_ARMI_INTERFACE on the requirement R_ARMI_INTERFACE


Checklist

@john-science john-science requested a review from drewj-tp July 9, 2025 17:38
@john-science john-science linked an issue Jul 9, 2025 that may be closed by this pull request
@john-science
Copy link
Member Author

Do not merge this yet.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Jul 9, 2025
@drewj-tp
Copy link
Contributor

LMK when this is ready for prime time 😸

@keckler
Copy link
Member

keckler commented Jul 22, 2025

This will break benchmarks

@john-science
Copy link
Member Author

This will break benchmarks

We can talk offline, but I was expecting this to need a couple of small PRs downstream that I would make for everyone.

@john-science john-science requested a review from keckler August 15, 2025 17:25
@john-science
Copy link
Member Author

@keckler We should talk about your benchmark reactors. I would happily make (what I can only assume are very small changes) in your benchmark repos to help push this ARMI change through. Just give me a list of the affecting repos offline, and I can try to take it from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code/comment cleanup: Low Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interface.function needs to be renamed

4 participants