-
Notifications
You must be signed in to change notification settings - Fork 97
Moving to use Reactor.nuclideBases, where possible
#2335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
john-science
wants to merge
45
commits into
main
Choose a base branch
from
step1_global_nuclides
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping me offline when you're ready for a review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change? Why is it being made?
This PR is non-API-breaking progress on ticket number 473. This is a follow up to the step 0 PR and the thermal scatter redesign PR.
In this PR, I try to get rid of the global access to
nuclideBasesinformation wherever possible. I am STILL using the global data, as this PR is not API-breaking in any way. But I switch to using the reference ofReactor.nuclideBases. The goal of this PR is to finish off ALL the work we can do to get rid of global nuclides, without breaking the ARMI API. As such, this is a big PR with a lot of little changes:Architectural Changes
Reactor.nuclideBasesto the Reactor constructornuclideBasesproperty to every Composite, to try and grab nuclides from the ReactorCase._initBurnChainnow takes r as an inputaddToGlobalstuff from PR number 2303.Switched from using Global to
r.nuclideBaseswhere EasySCR Information
Change Type: features
One-Sentence Description: Moving to use
Reactor.nuclideBases, where possible.One-line Impact on Requirements:
I_ARMI_ND_ELEMENTS0forR_ARMI_ND_ELEMENTS0is being rewritten to be less global. All implementation tags forR_ARMI_ND_ISOTOPESshould be considered touched, as we are rewriting that code to be less global. TouchedI_ARMI_Rbecause we added a property to theReactorclass. Minor tweak toT_ARMI_UTIL_EXP_MASS_FRACS, but no meaningful change.Checklist
docfolder.pyproject.toml.