Skip to content

feat(webview): show VIN as a Tooltip on car name#4861

Draft
Helvio88 wants to merge 10 commits into
teslamate-org:mainfrom
Helvio88:main
Draft

feat(webview): show VIN as a Tooltip on car name#4861
Helvio88 wants to merge 10 commits into
teslamate-org:mainfrom
Helvio88:main

Conversation

@Helvio88
Copy link
Copy Markdown

image

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 31, 2025

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit 268ead6
🔍 Latest deploy log https://app.netlify.com/projects/teslamate/deploys/68af3b5a2970820008525467
😎 Deploy Preview https://deploy-preview-4861--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Helvio88
Copy link
Copy Markdown
Author

Feel free to squash commits to get rid of my back and forth attempts to do a clipboard copy :)
I couldn't figure out a test environment.

@JakobLichterfeld JakobLichterfeld added the area:teslamate Related to TeslaMate core label Aug 5, 2025
Copy link
Copy Markdown
Member

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for your contribution!

I could see some users might want this addition.

Please update the test accordingly.

@JakobLichterfeld
Copy link
Copy Markdown
Member

Please also lint your code correctly: https://docs.teslamate.org/docs/development#code-formatting

@JakobLichterfeld JakobLichterfeld marked this pull request as draft August 5, 2025 16:39
@JakobLichterfeld JakobLichterfeld changed the title VIN as a Tooltip behing Car's Name feat(webview): show VIN as a Tooltip on car name Aug 5, 2025
@Helvio88 Helvio88 marked this pull request as ready for review August 26, 2025 20:40
@Helvio88
Copy link
Copy Markdown
Author

I believe I did what was needed :)

@JakobLichterfeld JakobLichterfeld marked this pull request as draft September 18, 2025 15:17
@JakobLichterfeld JakobLichterfeld added this to the v2.1.2 milestone Sep 18, 2025
@Helvio88
Copy link
Copy Markdown
Author

Hi Jakob,
I don't believe I made any dependency changes. Can you give me a pointer on where to begin looking to fix this?

@JakobLichterfeld
Copy link
Copy Markdown
Member

JakobLichterfeld commented Sep 19, 2025

I don't believe I made any dependency changes. Can you give me a pointer on where to begin looking to fix this?

Ah, this is due to line changes. You need re-generate the pot files, so they get correct line numbers, see
https://docs.teslamate.org/docs/development#update-pot-files-extract-messages-for-translation

Please rebase to main first.

If we get any merge issues later on, due to other translation changes with other PR's, I will take care of the merge conflicts.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the Stale label Mar 16, 2026
@github-actions github-actions Bot removed the Stale label May 2, 2026
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 10, 2026

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:teslamate Related to TeslaMate core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants