feat: remove change and changeInput in favor of rerender #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Use erender instead of change. Use erender instead of changechangeInput For more info see #365
timdeschryver
force-pushed
the
remove-deprecations
branch
from
4173951 to
9666dce
Compare
timdeschryver
commented
Mar 27, 2023
| expect(screen.getByText(`${firstName} ${lastName}`)).toBeInTheDocument(); | ||
|
|
||
| const firstName2 = 'Chris'; | ||
| await rerender({ componentInputs: { firstName: firstName2 } }); |
There was a problem hiding this comment.
It seems like this test fails while using componentInputs instead of componentProperties.
Do you think this is the expected behavior @shaman-apprentice ?
Changes is {} here.
There was a problem hiding this comment.
I think the test should pass. On a first glance I don't know why it doesn't. Unfortunately, I am busy at the moment. When you want to create an issue for it, I promise to dig into it within the next 2-3 weeks. A quick look if you find a solution faster is of course very welcome.
There was a problem hiding this comment.
I found a few minutes to deal with it. #380 will fix it. Good catch and thanks a lot for adding this test!
timdeschryver
added a commit
that referenced
this pull request
May 1, 2023
* feat: upgrade to @testing-library/dom 9 (#376) BREAKING CHANGE: For more info see https://github.com/testing-library/dom-testing-library/releases/tag/v9.0.0 * feat: remove change and changeInput in favor of rerender (#378) BREAKING CHANGE: Use `rerender` instead of `change`. Use `rerender` instead of `changechangeInput`. For more info see #365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Use
rerenderinstead ofchange.Use
rerenderinstead ofchangechangeInput.For more info see #365