React 18 cleanup #819
Merged
React 18 cleanup #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpeyper
added
docs
❌ Deploy Preview for react-hooks-testing-library failed.
|
BREAKING CHANGE: type dependencies will not longer be automatically installed. If @types/react is not already listed in your package.json, please install it with `npm install --save-dev @types/react@^17`.
mpeyper
force-pushed
the
react-18-cleanup
branch
from
d645d14 to
eda0113
Compare
Codecov Report
@@ Coverage Diff @@
## main #819 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 246 246
Branches 34 34
=========================================
Hits 246 246 Continue to review full report at Codecov.
|
|
Hmm.... I don't know why netlify is suddenly failing with an error from gatsby. I guess just the note in README will have to do. |
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Update a bunch of dependencies that that have been waiting in other PRs for a while nowWhy:
Mostly to stop accidentally resolving type versions that will break things for people and to try to remove any confusion about why we aren't suporting React 18 yet.
How:
I've made the type changes a BREAKING CHANGE to be extra cautious for our users in case they need to install the dependencies themselves now, but the update should not require any code changes for anyone.
If all the build check pass for this I will just merge it without waiting for reviews.