docs: be more specific about current Angular's rerender behavior #1213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
shaman-apprentice
force-pushed
the
docs/653/angular-rerender
branch
from
781c472 to
af8cd40
Compare
docs/angular-testing-library/api.mdx
Outdated
| @@ -411,8 +411,8 @@ expect(screen.getByTestId('name-value').textContent).toBe('Sarah') | |||
|
|
|||
| ### `rerender` | |||
|
|
|||
| Re-render the same component with different props. Input properties that are not | |||
| defined are cleared. This calls `detectChanges` after the props are updated. | |||
| Create and render a new instance of the component. | |||
There was a problem hiding this comment.
I would like to keep a note about "Input properties that are not
defined are cleared.".
Now that I see this, this is also the reason that change and rerender exist.
With change you can't clear input properties.
There was a problem hiding this comment.
I updated the PR. Please let me know what you think. I also created testing-library/angular-testing-library#365 for further discussion. Thanks again for your great fast responses :)
timdeschryver
approved these changes
Feb 9, 2023
|
@all-contributors please add @shaman-apprentice for docs |
|
I've put up a pull request to add @shaman-apprentice! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #653