Skip to content

Commit

Permalink
Fix code after linter changes
Browse files Browse the repository at this point in the history
  • Loading branch information
thaapasa committed Feb 25, 2024
1 parent e886ecc commit f196e26
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 18 deletions.
4 changes: 2 additions & 2 deletions src/client/ui/expense/row/ExpenseRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,8 @@ export class ExpenseRowImpl extends React.Component<ExpenseRowProps, ExpenseRowS
background: !expense.confirmed
? colors.unconfirmedStripes
: expense.type === 'income'
? colors.income
: undefined,
? colors.income
: undefined,
};
if (!expense.confirmed) {
style.background = colors.unconfirmedStripes;
Expand Down
4 changes: 2 additions & 2 deletions src/server/data/ExpenseSearch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ export async function getExpenseSearchQuery(
const type = Array.isArray(query.type)
? query.type
: isDefined(query.type)
? [query.type]
: undefined;
? [query.type]
: undefined;
const inputCategoryIds =
typeof query.categoryId === 'number' ? [query.categoryId] : query.categoryId || [];
const categoryIds =
Expand Down
11 changes: 8 additions & 3 deletions src/server/logging/TraceIdProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,23 +40,28 @@ type LogMethod = (typeof LogMethods)[number];
* Instruments the Pino logger to automatically grab the request id from
* the AsyncLocalStorage and add it to the log output.
*/
export function instrumentLogger(logger: Logger): Logger {
export function instrumentLogger<CustomLevels extends string = never>(
logger: Logger<CustomLevels>,
): Logger<CustomLevels> {
if (!config.logRequestId) {
return logger;
}
// Replace each logger method an instrumented version
LogMethods.forEach(m => transformLogFn(logger, m));

// Auto-instrument all child loggers
const orgChild = logger.child;
const orgChild = logger.child<any>;
logger.child = (bindings, options) => {
const childLogger = orgChild.call(logger, bindings, options);
return instrumentLogger(childLogger) as any;
};
return logger;
}

function transformLogFn(logger: Logger, method: LogMethod) {
function transformLogFn<CustomLevels extends string = never>(
logger: Logger<CustomLevels>,
method: LogMethod,
) {
const orgImpl = logger[method];
logger[method] = (...args: any[]) => {
const state = getCurrentTraceState();
Expand Down
2 changes: 1 addition & 1 deletion src/server/server/FileHandling.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { writeFile } from 'fs/promises';
import multipart from 'parse-multipart-data';
import path from 'path';
import { ITask } from 'pg-promise';
import { promisify } from 'sys';
import { promisify } from 'util';

import { BkError, SessionBasicInfo } from 'shared/types';
import { config } from 'server/Config';
Expand Down
11 changes: 5 additions & 6 deletions src/server/server/ServerControl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,11 @@ let runningServer: Server | undefined = undefined;
function closeRunningServer() {
const s = runningServer;
if (!s) return Promise.resolve();
return new Promise(
(resolve, reject) =>
s?.close(err => {
if (err) reject(err);
else resolve(err);
}),
return new Promise((resolve, reject) =>
s?.close(err => {
if (err) reject(err);
else resolve(err);
}),
);
}

Expand Down
8 changes: 4 additions & 4 deletions src/server/server/ValidatingRouter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ type ValidatorSpec<R, Q, B> = {
type PathToParams<Path extends string> = Path extends `${infer Start}/${infer Rest}`
? PathToParams<Start> & PathToParams<Rest>
: Path extends `:${infer Param}`
? {
[k in Param]: k extends keyof KnownTypes ? KnownTypes[k] : unknown;
}
: unknown;
? {
[k in Param]: k extends keyof KnownTypes ? KnownTypes[k] : unknown;
}
: unknown;

type HandlerParams<Path extends string, Q, B> = {
params: PathToParams<Path>;
Expand Down

0 comments on commit f196e26

Please sign in to comment.