[Java] Adding Armeria 1.26.4 #7061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waghanza
requested changes
Dec 19, 2023
waghanza
reviewed
Dec 19, 2023
|
Yes, please. Thank yo for your contribution!
|
|
Addressed your code review comments, thanks! |
waghanza
requested changes
Dec 19, 2023
java/armeria/src/main/java/benchmark/armeria/BenchmarkApplication.java
Outdated
Show resolved
Hide resolved
|
Sorry, CI reveals some errors (500). You should have 3 endpoints :
|
|
No problem. I goofed up the code and misunderstood your POST comment but I just ran the rspec locally and now it passes. |
waghanza
reviewed
Dec 19, 2023
java/armeria/pom.xml
Outdated
| <maven.compiler.source>21</maven.compiler.source> | ||
| <maven.compiler.target>21</maven.compiler.target> | ||
| <armeria.version>[1.26, 1.27)</armeria.version> | ||
| <slf4j.version>1.7.36</slf4j.version> |
There was a problem hiding this comment.
May we use the latest version in maven ? I mean using something dynamic, like + to make sure the build use the latest version available
waghanza
approved these changes
Dec 20, 2023
|
Results available at https://web-frameworks-benchmark.netlify.app/result?f=armeria&l=java |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.