Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix automatic sort of Composite items in fixed containers #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EricRibeiro
Copy link
Member

@EricRibeiro EricRibeiro commented Apr 18, 2021

Closes #2

How to test?

Check generated CodeSandbox: https://codesandbox.io/s/cold-rain-fkr5b

Does this PR introduce breaking changes?

No

@EricRibeiro EricRibeiro requested a review from RonanFelipe April 18, 2021 00:53
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 905a747:

Sandbox Source
Reakit Configuration
cold-rain-fkr5b Issue #2

@RonanFelipe
Copy link

Thanks for working on this @EricRibeiro! I'll take a look at it this weekend (hopefully).

@github-actions
Copy link

Size Change: 0 B

Total Size: 257 kB

ℹ️ View Unchanged
Filename Size Change
packages/reakit-playground/dist/reakit-playground.min.js 187 kB 0 B
packages/reakit-system-bootstrap/dist/reakit-system-bootstrap.min.js 19.1 kB 0 B
packages/reakit-system-palette/dist/reakit-system-palette.min.js 8.85 kB 0 B
packages/reakit-system/dist/reakit-system.min.js 2.45 kB 0 B
packages/reakit-utils/dist/reakit-utils.min.js 3.46 kB 0 B
packages/reakit/dist/reakit.min.js 36 kB 0 B

compressed-size-action

@mairieli
Copy link

I'm also hitting this issue on a regular basis, it can be quite jarring on a long page – thanks for taking on the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composite automatic sort doesn't work on fixed containers
3 participants