Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added visual timers section and various bug fixes #93

Merged
merged 13 commits into from
Feb 1, 2025
Merged

Added visual timers section and various bug fixes #93

merged 13 commits into from
Feb 1, 2025

Conversation

Wraiith32
Copy link
Contributor

I have added a visual timers section for friends who do not hear the audio notification that always asks, "Has the run-through timer passed yet?"

image

Timers:

  • Time in Raid
  • Runthrough Period Countdown
  • Scav Cooldown Countdown

Additional Changes:

  • Moved runthrough value to settings in an attempt to reduce duplicative values.
  • added "#if DEBUG" around Debug.WriteLine statements in GameWatcher_NewLogData. Code does not exist in the release build; it will only exist and run in debug mode.
  • automaticallyDeleteScreenshotsAfterRaid was missing from settings -- added.
  • added message.add for runthrough alert so it shows up in messages.

Bug Fix

  • air filter notification was not working due to normalizedName always returning null. Query did not include normalizedName - fixed.

@Wraiith32
Merge pull request #1 from the-hideout/master
3a89163 
Rebasing to Master
@Wraiith32
Added a message when the runthrough period has past.
5b30a2d
@Wraiith32
Change RunThrough Time to read from settings instead of being hardcod…
4a44e71 
…ed. Default value to 00:07:10
@Wraiith32
First iteration of Timers screen to show Time In Raid, Runthrough Tim…
bdd32ad 
…er left, and Scav Cool down -- for those who do not hear or play with team mates that do not hear the audio. Need to rework event system to try reduce duplicate code.
@Wraiith32
Added #if DEBUG around commented out Debug.WriteLine to make it easie…
661c541 
…r to see debug messages anytime you are running in debug mode.
@Wraiith32
Changed to System.Threading.Timers
91a39a0
@Wraiith32
Updated version number.
ad7efbd
@Wraiith32
Update README.md
ccd8e10 
Added description of visual timers.
@Wraiith32
NormalizedName of object was always null. Traced back and noticed tha…
7074274 
…t normalizedName was not included in query. Air Filter Notification was never working. Should be fixed now.
@Wraiith32
Redesigned how the visual timers work by creating a service that will…
0c52ed0 
… be usable whether the UI is displayed or not.
@Wraiith32
Merge branch 'feature/remaining_time' of https://github.com/Wraiith32…
a257675 
…/TarkovMonitor into feature/remaining_time
@Razzmatazzz
Copy link
Member

Thanks for the PR! Sorry for the delay in merging it, but I should be able to test, merge, and push out a new release this weekend.

@Wraiith32
Copy link
Contributor Author

Thanks for the PR! Sorry for the delay in merging it, but I should be able to test, merge, and push out a new release this weekend.

Do not sweat it! We all have lives ;)

Razzmatazzz
Razzmatazzz approved these changes Feb 1, 2025
View reviewed changes
Copy link
Member

@Razzmatazzz Razzmatazzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR!

@Razzmatazzz Razzmatazzz merged commit 5cc0478 into the-hideout:master Feb 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razzmatazzz Razzmatazzz Razzmatazzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wraiith32 @Razzmatazzz