Skip to content

Add github workflow file to deploy docs to pages#59

Merged
JimMadge merged 13 commits intomainfrom
pages_deploy
Jul 9, 2025
Merged

Add github workflow file to deploy docs to pages#59
JimMadge merged 13 commits intomainfrom
pages_deploy

Conversation

@thomaszwagerman
Copy link
Contributor

Publishing docs to Github Pages on push to main.

A repeat of #51, which was closed without merging by accident during the hectic last few minutes of the hack day!

This will require @RayStick to configure publishing source in the repo settings.

Also see mkdocs publishing instructions.

If this is moving across to TTW(?) it might be easier to hold off merging until that is done?

@RayStick
Copy link
Contributor

RayStick commented May 21, 2025

Thanks @thomaszwagerman I made the changes - does that look right?
Or will the GitHub pages site be built from a different branch?
Good point about possibly holding off if we are moving to TTW. Thoughts @JimMadge or @sgibson91 ?

Screenshot 2025-05-21 at 17 31 21

@thomaszwagerman
Copy link
Contributor Author

I think under Branch main will have to become gh-pages, but that branch won't exist until we activate this action.

(it might do that automatically though, I can't remember)

@sgibson91
Copy link
Member

I think @JimMadge and I would be happy to move this repo to TTW's org if there's no objections from the rest of the hackday team?

@JimMadge
Copy link
Member

If we do a proper GitHub migrate, I think we retain the issues, PRs, and so on.

Might need to give @RayStick extra permissions temporarily on @the-turing-way to do that. If you let me know if/when you'd like to do that I can sort it out 👍.

@sgibson91
Copy link
Member

@RayStick if you give either/both myself and @JimMadge Owner rights to the repo, we can move it ourselves :)

@RayStick
Copy link
Contributor

RayStick commented May 27, 2025

@JimMadge I requested a transfer to your account! (@sgibson91 it did not work for you, probably because you have a fork of the same name). Hopefully this allows you to then bring it to TTW og😌

@JimMadge
Copy link
Member

I think changing my or @sgibson91's role to Owner is probably the best solution. That way we can avoid transferring the repo twice. Or, can you request a transfer directly to The Turing Way?

@RayStick
Copy link
Contributor

RayStick commented May 27, 2025

Sure. I need write access to transfer direct to TTW org. I didn't see an option to add you as an owner, but let me check again!

EDIT: A personal public GH repo doesn't seem to have as many granular options for permissions for collaborators. It needs to be a repo within an organization for that

@JimMadge
Copy link
Member

@RayStick I've sent you an invitation to the org, that should give you the permission to create repos (and hence transfer this repo 🤞). Let me know if that works.

@RayStick
Copy link
Contributor

Done 🥳

@thomaszwagerman
Copy link
Contributor Author

@sgibson91 @JimMadge now that this is on TTW - do feel free do adapt the docs/hosting methods completely as you see fit, if there is some standardised theme/hosting infrastructure this should align to etc

@RayStick
Copy link
Contributor

@sgibson91 @JimMadge now that this is on TTW - do feel free do adapt the docs/hosting methods completely as you see fit, if there is some standardised theme/hosting infrastructure this should align to etc

And let me know if I can help with the docs in any way :)

Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.

Most importantly, I think we shouldn't have a different build command here than in the pyproject.toml.

@JimMadge
Copy link
Member

@sgibson91 @JimMadge now that this is on TTW - do feel free do adapt the docs/hosting methods completely as you see fit, if there is some standardised theme/hosting infrastructure this should align to etc

GitHub Pages seems sensible to me.

thomaszwagerman and others added 6 commits May 29, 2025 09:18
Co-authored-by: Jim Madge <jim+github@jmadge.com>
Co-authored-by: Jim Madge <jim+github@jmadge.com>
Co-authored-by: Jim Madge <jim+github@jmadge.com>
Co-authored-by: Jim Madge <jim+github@jmadge.com>
Co-authored-by: Jim Madge <jim+github@jmadge.com>
@RayStick
Copy link
Contributor

RayStick commented Jul 9, 2025

What needs to be done to get this documentation PR merged?

It is out of date now, so I am hesitant to be the one that reviews and merges it - @sgibson91 and @JimMadge what do you think?

Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimMadge JimMadge merged commit a17120a into main Jul 9, 2025
4 checks passed
@JimMadge JimMadge deleted the pages_deploy branch July 9, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants