Update build and push workflow

[JimMadge]

Some tidying and updating of the build/push behaviour for container images on ghcr. Inspired by wanting to pin specific version in our actions, see #66.

Should automate tagging container images with suitable version tags, which we can then use in the action to help people stick to a particular release of the code.
This should make the syncing between action version and container version easier.

• Use https://github.com/marketplace/actions/docker-metadata-action to simplify workflow
• Make behaviour more consistent (login, generate metadata, and push for all triggers but pull requests)
• Push tags for
  • full version
  • major.minor version
  • major version
  • commit sha

[sgibson91]

You realise this won't keep the action and container version in sync at all because it doesn't do anything to the action.yaml file right? (Not against the changes at all, just wanting to make sure we share understanding of what's actually happening)

[JimMadge]

You realise this won't keep the action and container version in sync at all because it doesn't do anything to the action.yaml file right? (Not against the changes at all, just wanting to make sure we share understanding of what's actually happening)

Yep that is right. It automates the tagging of container images with labels taken from a git tag. But it doesn't do anything to make sure those tags are correct or in sync with action.yaml.

[sgibson91]

FYI, this will work now we're in the-turing-way org, but the reason I had the "downcase" step above is because the push to ghcr will fail if there are capital letters in the image name. Rachael had capital letters in her GitHub handle, which is why I added the step.

Is it worth keeping this lower casing logic somewhere just so the workflow is robust to any future org/repo name changes? Doesn't have to be in exactly the same form I had above.

[JimMadge]

Oh, good knowledge. I wouldn't have guessed that.

[JimMadge]

I would say remove it as it isn't necessary, less to maintain and no risk of confusion.

[sgibson91]

Hmmmm, build failed https://github.com/the-turing-way/all-all-contributors/actions/runs/16523079997/job/46729361897

I'm about to go into a meeting so can't debug right this second

[JimMadge]

Error: buildx failed with: ERROR: failed to build: tag is needed when pushing to registry

So something isn't going right with passing the tags to the build action.

From the metadata action,

 {
    "target": {
      "docker-metadata-action": {
        "tags": [
          "ghcr.io/the-turing-way/all-all-contributors:edge",
          "ghcr.io/the-turing-way/all-all-contributors:sha-eea9217"
        ],
        "args": {
          "DOCKER_META_IMAGES": "ghcr.io/the-turing-way/all-all-contributors",
          "DOCKER_META_VERSION": "edge"
        }
      }
    }
  }

The tags are being generated, but I don't think that is doing quite what we want. I thought the edge thing would create a tag called main.

[sgibson91]

@JimMadge PR #69 got us a tag called main, but the push is still failing due to the same error that you found

Error: buildx failed with: ERROR: failed to build: tag is needed when pushing to registry

  {
    "target": {
      "docker-metadata-action": {
        "tags": [
          "ghcr.io/the-turing-way/all-all-contributors:main",
          "ghcr.io/the-turing-way/all-all-contributors:sha-6769416"
        ],
        "args": {
          "DOCKER_META_IMAGES": "ghcr.io/the-turing-way/all-all-contributors",
          "DOCKER_META_VERSION": "main"
        }
      }
    }
  }

[JimMadge]

Yep, sorry. It isn't obvious to me what is wrong so I need to find some time to debug this 😅

[sgibson91]

Oh yeah, me neither. I just took some opportunistic time last night to have a look myself 😄

[RayStick]

@all-contributors add @JimMadge for infrastructure

[allcontributors]

@RayStick

I've put up a pull request to add @JimMadge! 🎉