Add support to ignore people in channel #2
Conversation
|
👏 , LGTM 🚀 |
| @default_greeting """ | ||
| Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. | ||
| Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. | ||
| Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. | ||
| Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum | ||
| """ | ||
| @ignore_people ["hugh", "ricardo", "victor"] |
There was a problem hiding this comment.
This should be in env variables (or in a config file not pushed) as this is intended to be a public and easy-to-reuse tool.
There was a problem hiding this comment.
Maybe a comma separated string as an ENV variable read from application's config file and parsed in the config function can be a good option.
There was a problem hiding this comment.
does Slack give access to each users notification preferences for a channel? maybe ignore people who have notifications turned off
There was a problem hiding this comment.
or create a user group for people who can lunch and use that instead of all members of the channel
There was a problem hiding this comment.
I like the idea of using a user group, seems that it is possible, https://api.slack.com/methods/usergroups.list, what do you you think @pilu ?
|
ENV 🙌 remember to document 📚 |
This PR adds support to ignore some people. Thanks to this, people working remotely can join the channel and they are not going to be selected for lunch.