Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: error occured when try to connect already connected VPN #22

Closed

Conversation

thamaraiselvam
Copy link

resolved #21

Copy link
Member

@dineshba dineshba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am yet to update to mojave. So not able to test it.

@arunvelsriram arunvelsriram requested a review from jskswamy October 3, 2019 17:29
@arunvelsriram
Copy link
Member

Thanks for the PR. I don't have access to any IPSec VPNs to test this.

@jskswamy / @prabhu43 could one of you test and review the PR?

@jskswamy
Copy link
Contributor

jskswamy commented Oct 4, 2019

I still see the following error

execution error: System Events got an error: Can’t get button "Authentication Settings…" of group 1 of window 1 of process "System Preferences". (-1728)

@thamaraiselvam
Copy link
Author

@jskswamy that is different error Issue created already #20

@thamaraiselvam
Copy link
Author

resolved #20

Can’t get button "Authentication Settings issue also merged with this PR.

It happens because it could not find the exact name match sometimes. so changed to contains

@jskswamy
Copy link
Contributor

@thamaraiselvam mojave fix has been merged into master, kindly raise a PR against master

@jskswamy jskswamy closed this Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants