Use << to add missing city to the list#66
Open
duduribeiro wants to merge 1 commit intothecodecrate:mainfrom
Open
Use << to add missing city to the list#66duduribeiro wants to merge 1 commit intothecodecrate:mainfrom
duduribeiro wants to merge 1 commit intothecodecrate:mainfrom
Conversation
Instead of using `@cities[country][state] = new_value`, use `<<` to add the missing city into the cities list
Author
|
hey @loureirorg 👋 Just pinging to check if this one and #68 are valids. Just wanted a bump of version so I can use this instead of a fork 😄 Thanks! |
|
@loureirorg Any news on this one? We are also running a local fork just to circumvent this issue. |
|
We still waiting :) |
duduribeiro
added a commit
to duduribeiro/civitas
that referenced
this pull request
Feb 19, 2025
City-state has two problemas that is prohibiting using the gem on most recente ruby versions: - thecodecrate#68 - thecodecrate#66 This commit applies these fixes
Author
Hey @anko20094 👋 I tried to reach @loureirorg about these but without success. I created a new gem https://github.com/duduribeiro/civitas https://rubygems.org/gems/civitas which contains these fixes and I will try to apply future fixes as well, since I use these gem. It is an easy drop-in replacement for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks 👋
I'm using ruby 3.2.2 and having a issue when adding a missing city. I added this yml to my project:
db/cities-lookup.ymlbut when I run
to test it fails for me because:
I think the idea of this line is to add a new_value to the existing array, so I changed it to include the new line