feat: admin crud #44
Open
feat: admin crud #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
imrim12
requested changes
Nov 17, 2024
Comment on lines
4
to
5
| import { usePermissionStore } from '~/stores/admin/permission' | ||
| import type { PivotRolePermission, Role } from '~/stores/admin/role' |
There was a problem hiding this comment.
Suggested change
| import { usePermissionStore } from '~/stores/admin/permission' | |
| import type { PivotRolePermission, Role } from '~/stores/admin/role' | |
| import { usePermissionStore } from '@base/stores/admin/permission' | |
| import type { PivotRolePermission, Role } from '@base/stores/admin/role' |
Comment on lines
19
to
21
| const permissionStore = usePermissionStore() | ||
| const { permissionList } = storeToRefs(permissionStore) | ||
| const { fetchPermissions } = permissionStore |
There was a problem hiding this comment.
don't destructure it
Suggested change
| const permissionStore = usePermissionStore() | |
| const { permissionList } = storeToRefs(permissionStore) | |
| const { fetchPermissions } = permissionStore | |
| const permissionStore = usePermissionStore() |
There was a problem hiding this comment.
don't store permissions list in store also
| if (!isIndeterminate.value) | ||
| isSelectAll.value = false | ||
| watch(queryOptions.value, async () => { | ||
| await fetchPermissions(queryOptions.value) |
There was a problem hiding this comment.
Suggested change
| await fetchPermissions(queryOptions.value) | |
| await permissionStore.fetchPermissions(queryOptions.value) |
| // 👉 select all and none | ||
| const isSelectAll = computed(() => { | ||
| return ( | ||
| localRoleData.value.permissions?.length === permissionList.value.length |
There was a problem hiding this comment.
Suggested change
| localRoleData.value.permissions?.length === permissionList.value.length | |
| formData.value.permissions?.length === permissionData.value.length |
| permissions: permissions.value, | ||
| } | ||
| function handleCheckAllPermissions() { | ||
| localRoleData.value.permissions = [...permissionList.value] |
There was a problem hiding this comment.
Suggested change
| localRoleData.value.permissions = [...permissionList.value] | |
| formData.value.permissions = [... permissionData.value] |
Comment on lines
171
to
176
| <VBtn | ||
| :color="isSelectAll ? 'primary' : 'secondary'" | ||
| variant="text" | ||
| text="All" | ||
| @click="handleCheckAllPermissions" | ||
| /> |
There was a problem hiding this comment.
Suggested change
| <VBtn | |
| :color="isSelectAll ? 'primary' : 'secondary'" | |
| variant="text" | |
| text="All" | |
| @click="handleCheckAllPermissions" | |
| /> | |
| <VBtn | |
| :color="isSelectAll ? 'primary' : 'secondary'" | |
| variant="text" | |
| @click="handleCheckAllPermissions" | |
| > | |
| All | |
| </VBtn> |
| /> | ||
|
|
||
| <VBtn | ||
| :color="localRoleData?.permissions?.length === 0 ? 'primary' : 'secondary'" |
There was a problem hiding this comment.
Suggested change
| :color="localRoleData?.permissions?.length === 0 ? 'primary' : 'secondary'" | |
| :color="formData?.permissions?.length ? 'secondary' : 'primary'" |
| </VTable> | ||
| <!-- 👉 Role Permissions --> | ||
| <div class="mt-6 d-flex flex-wrap gap-3 permission-container"> | ||
| <div v-for="permission in permissionList" :key="permission.id" class="d-flex align-center gap-2 flex-wrap"> |
There was a problem hiding this comment.
Suggested change
| <div v-for="permission in permissionList" :key="permission.id" class="d-flex align-center gap-2 flex-wrap"> | |
| <div v-for="permission in permissionData" :key="permission.id" class="d-flex align-center gap-2 flex-wrap"> |
app/pages/test-organization.vue
Outdated
Comment on lines
3
to
5
| import { DRAWER_ACTION_TYPES } from '~/constant/organization' | ||
| import type { DrawerConfig } from '~/utils/types' | ||
| import type { DrawerActionTypes } from '~/utils/types/landing-page' |
There was a problem hiding this comment.
Suggested change
| import { DRAWER_ACTION_TYPES } from '~/constant/organization' | |
| import type { DrawerConfig } from '~/utils/types' | |
| import type { DrawerActionTypes } from '~/utils/types/landing-page' | |
| import { DRAWER_ACTION_TYPES } from '@base/constant/organization' | |
| import type { DrawerConfig } from '@base/utils/types' | |
| import type { DrawerActionTypes } from '@base/utils/types/landing-page' |
app/stores/admin/permission.ts
Outdated
| const totalPermissions = ref(0) | ||
| const permissionDetail = ref<Permission | null>(null) | ||
| const permissionDetail = ref<PermissionWithRelations | null>(null) | ||
|
|
||
| async function fetchPermissions(options?: ParsedFilterQuery) { |
imrim12
force-pushed
the
feat/admin-crud
branch
3 times, most recently
from
c489538 to
9cb46a6
Compare
imrim12
force-pushed
the
feat/admin-crud
branch
from
9cf0f08 to
b7d7055
Compare
imrim12
force-pushed
the
feat/admin-crud
branch
from
ae6b9f7 to
c6e97f2
Compare
imrim12
force-pushed
the
main
branch
2 times, most recently
from
6abc134 to
71bb78e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.