Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow callable() as field deferring mechanism #739

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

oprypkhantc
Copy link
Contributor

@oprypkhantc oprypkhantc commented Mar 15, 2025

Closes #738

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2025

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.85%. Comparing base (53f9d49) to head (30a4f95).
Report is 111 commits behind head on master.

Files with missing lines Patch % Lines
src/Mappers/CannotMapTypeException.php 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #739      +/-   ##
============================================
- Coverage     95.72%   94.85%   -0.87%     
- Complexity     1773     1838      +65     
============================================
  Files           154      175      +21     
  Lines          4586     4999     +413     
============================================
+ Hits           4390     4742     +352     
- Misses          196      257      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

public function getSubBlogs(
#[Prefetch('prefetchSubBlogs')]
array $prefetchedSubBlogs,
): Deferred {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this test as well, instead of replacing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleaner and simpler field deferring
3 participants