-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle FuncCall nodes that represent first class callables #32
base: master
Are you sure you want to change the base?
Handle FuncCall nodes that represent first class callables #32
Conversation
33e3983
to
abaeae5
Compare
@dbrekelmans I rebased atop the latest changes. I think #33 and this can be applied independently from one another. The condition I put to check for first class callables should come before the condition added there. |
Hi all, new maintainer here, hoping to get this merged if it's still relevant. Coming in with little context, what does the PR do? Could it include a unit test showing what fails now, and succeeds after the patch is applied? (There are merge conflicts and failing tests, and I daren't try to fix it myself without understanding the intention behind the code 😅 ) |
…first-class-callable # Conflicts: # composer.json # src/Rules/UseSafeFunctionsRule.php
Thank you @shish for looking into this. I tried adding a failing test. I think first-class callables should also be recognized by this rule, such as |
I have enabled the CI, but it looks like the added unit test is failing both before and after the changes to add support for it o.o;; |
Stumbled upon this while working on a fix for #31. The original fix no longer applies, but I think this is still valuable to ensure PHP 8.1 compatibility.