Fixes #39350 - implement expandable rows for task info#818
Fixes #39350 - implement expandable rows for task info#818andreilakatos wants to merge 2 commits into
Conversation
andreilakatos
changed the title
andreilakatos
force-pushed
the
taskdetails-pf5-taskinfo-expandable
branch
from
8ca0c37 to
78e7393
Compare
|
@andreilakatos Rebase the commit onto master so it won't be dependent on #817 please |
This PR depends a bit on 817, I'm not sure it's a good idea to do that. I'll have to fix some weird conflicts after that again. |
| {help && ( | ||
| <GridItem span={12}> | ||
| <b>{__('Troubleshooting')}</b> | ||
| <p dangerouslySetInnerHTML={{ __html: help }} /> | ||
| </GridItem> | ||
| )} |
There was a problem hiding this comment.
Maybe I missed something, but where did the help go?
There was a problem hiding this comment.
Actually, that is removed from the design:
That's why it was removed.
Maybe Maria S wants to add it somewhere else
Sure, missed that one |
andreilakatos
force-pushed
the
taskdetails-pf5-taskinfo-expandable
branch
from
78e7393 to
f5f4c03
Compare
|
Done, added tests and rebased with the latest changes |
andreilakatos
force-pushed
the
taskdetails-pf5-taskinfo-expandable
branch
2 times, most recently
from
f03dd2c to
ee813d7
Compare
|
Rebase @andreilakatos |
andreilakatos
force-pushed
the
taskdetails-pf5-taskinfo-expandable
branch
from
ee813d7 to
c35f1b7
Compare
| title: 'Start before', | ||
| value: startBefore ? ( | ||
| <RelativeDateTime defaultValue={__('N/A')} date={startBefore} /> |
There was a problem hiding this comment.
Also not present in new design, can you please confirm @MariSvirik
| {help && ( | ||
| <GridItem span={12}> | ||
| <b>{__('Troubleshooting')}</b> | ||
| <p dangerouslySetInnerHTML={{ __html: help }} /> | ||
| </GridItem> | ||
| )} |
|
Test failures related @andreilakatos |
2 participants
Uh oh!
There was an error while loading. Please reload this page.