Fixes #38165 - Add checkboxes actions to job invocation page #944
+384
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kmalyjur
commented
Jan 28, 2025
kmalyjur
commented
- Open all failed button opens just host from the current page
1 task
MariaAga
reviewed
Jan 28, 2025
| attribute :name, :operatingsystem_id, :operatingsystem_name, :hostgroup_id, :hostgroup_name, :id | ||
| attribute :id, :name, :operatingsystem_id, :operatingsystem_name, :hostgroup_id, :hostgroup_name |
There was a problem hiding this comment.
Nope, just wrong rebase, sorry
Comment on lines
69
to
71
| `Task for the host ${ | ||
| action === 'cancel' ? 'cancelled' : 'aborted' | ||
| } successfully` |
There was a problem hiding this comment.
please ues 2 different strings so we wont have to do difficult translations
adamruzicka
requested changes
Jan 28, 2025
MariaAga
reviewed
Jan 28, 2025
Comment on lines
250
to
268
| <OpenAlInvocations | ||
| setShowAlert={setShowAlert} | ||
| results={results} | ||
| id={id} | ||
| /> | ||
| } | ||
| />, | ||
| <CheckboxesActions | ||
| jobID={id} | ||
| bulkParams={bulkParams} | ||
| failedHosts={failedHosts} | ||
| selectedCount={selectedCount} | ||
| currentPermissions={currentPermissions} | ||
| permissionsStatus={permissionsStatus} | ||
| />, | ||
| ]} | ||
| controller="hosts" | ||
| creatable={false} | ||
| replacementResponse={combinedResponse} | ||
| selectionToolbar={selectionToolbar} | ||
| updateSearchQuery={updateSearchQueryBulk} |
MariaAga
reviewed
Jan 28, 2025
| @@ -267,8 +350,14 @@ JobInvocationHostTable.propTypes = { | |||
| targeting: PropTypes.object.isRequired, | |||
| finished: PropTypes.bool.isRequired, | |||
| autoRefresh: PropTypes.bool.isRequired, | |||
| initialFilter: PropTypes.string.isRequired, | |||
There was a problem hiding this comment.
The prop `initialFilter` is marked as required in `JobInvocationHostTable`, but its value is `undefined`.
MariaAga
reviewed
Jan 28, 2025
|
|
||
| return ( | ||
| <> | ||
| <RerunButton /> |
There was a problem hiding this comment.
can you please space between rerun and open all in new tabs?
There was a problem hiding this comment.
Of course, sorry, I haven't even looked at it after rebasing
MariaAga
reviewed
Jan 28, 2025
| onClick={() => { | ||
| if (failedHosts.length <= 3) { | ||
| failedHosts.forEach(id => | ||
| openLink(`/job_invocations/${id}`, () => {}) |
There was a problem hiding this comment.
This should open /show_template_invocation_by_host/:host_id/job_invocation/:id
kmalyjur
force-pushed
the
job-inv-table-checkboxes-clean
branch
from
fe71baf to
121976e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.