-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
passing batch_size fix #647
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
==========================================
+ Coverage 78.52% 78.55% +0.03%
==========================================
Files 36 36
Lines 3828 3829 +1
Branches 672 672
==========================================
+ Hits 3006 3008 +2
Misses 547 547
+ Partials 275 274 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes, then we can merge. thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You write everywhere
Number of rows/columns of the cost matrix to
materialize during :meth:`push` or :meth:`pull`.
If :obj:`None`, the entire cost matrix will be materialized.
Larger value will require more memory.
Please swap the 3rd with the 4th line. First talk about non-None
, and then about None
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.