Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing batch_size fix #647

Merged
merged 9 commits into from
Jan 23, 2024
Merged

passing batch_size fix #647

merged 9 commits into from
Jan 23, 2024

Conversation

ArinaDanilina
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05530db) 78.52% compared to head (cd0e301) 78.55%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
+ Coverage   78.52%   78.55%   +0.03%     
==========================================
  Files          36       36              
  Lines        3828     3829       +1     
  Branches      672      672              
==========================================
+ Hits         3006     3008       +2     
  Misses        547      547              
+ Partials      275      274       -1     
Files Coverage Δ
src/moscot/base/problems/_mixins.py 85.37% <100.00%> (+0.54%) ⬆️
src/moscot/problems/cross_modality/_mixins.py 83.60% <ø> (ø)
src/moscot/problems/space/_mixins.py 81.64% <ø> (ø)
src/moscot/problems/time/_mixins.py 63.26% <ø> (ø)

@ArinaDanilina ArinaDanilina requested review from giovp and removed request for giovp January 20, 2024 14:48
@ArinaDanilina ArinaDanilina requested review from giovp and MUCDK January 20, 2024 15:11
Copy link
Collaborator

@MUCDK MUCDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes, then we can merge. thanks

@ArinaDanilina ArinaDanilina requested a review from MUCDK January 22, 2024 12:05
Copy link
Collaborator

@MUCDK MUCDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You write everywhere

Number of rows/columns of the cost matrix to 
materialize during :meth:`push` or :meth:`pull`.
If :obj:`None`, the entire cost matrix will be materialized.
Larger value will require more memory.

Please swap the 3rd with the 4th line. First talk about non-None, and then about None.

@ArinaDanilina ArinaDanilina requested a review from MUCDK January 23, 2024 10:03
Copy link
Collaborator

@MUCDK MUCDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MUCDK MUCDK merged commit 4617c94 into main Jan 23, 2024
6 checks passed
@MUCDK MUCDK deleted the add/pass_kwargs branch January 23, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants