-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to the 2. chapter: "Single-cell RNA sequencing"! #329
Conversation
…a note field until third generation sequencing (inclusive).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! A lot of fixes.
Have you already looked into content updates (new assays, removing unneeded text here, ...) or do you plan to make a follow up PR here?
Cells form open systems which maintain homeostasis, have a metabolism, grow, adapt to their environment, reproduce, respond to stimuli, and organize themselves. | ||
Therefore, cells are the fundamental building block of life which were first discovered in 1665 by the British scientist Robert Hooke. Hooke investigated a thin slice of cork with a very rudimentary microscope, and to his surprise noticed that the slice appeared to resemble a honeycomb. He named these tiny units 'cells'. | ||
Therefore, cells are the fundamental building blocks of life, and they were first discovered in 1665 by the British scientist Robert Hooke. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether we can actually drop all of this fluff although it's kinda cute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean just the first paragraph with Robert Hooke? Then, I would keep it. It's cute enough and the content will become more complicated anyway. So it's an easy introduction at the beginning.
Do you mean the whole "2.1 The building block of life" part? We could discuss making it shorter in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda both. So let's keep the first one an if you have ideas to make the second one shorter, I'm happy to see them implemented. But not a big deal.
No, I haven´t added new content yet. I can create a new follow-up branch or push current changes to this PR. Since I don't have much experience using Git Hub on larger projects, perhaps you can recommend one of these options. |
…s for the key takeaways
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Suggestion from Lukas 1 Co-authored-by: Lukas Heumos <[email protected]>
Suggestion from Lukas 2 Co-authored-by: Lukas Heumos <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These key takeaway boxes are a really really nice idea. Two comments:
- They seem to be a bit/long/verbose. Is there a way to make them shorter or take less space?
- We need to agree on a final design of these together with @seohyonkim so that we can roll them out in all chapters.
I solved some merge conflicts.
You can make a follow up PR then additional content improvements. It's good if we keep one PR with one concern.
…ab/single-cell-best-practices into feature/scRNA-seq-updates
I added a |
I love the see also. I think we could make the strengths and weaknesses maybe look nicer but it's fine. Let's merge this and then iterate. |
This is a good idea. I will keep that in mind for the next iteration! 👍 |
I cleaned the sentences (e.g., improved grammar, wording, small typing errors, etc. ) and added features like a note for sequencing length, the key takeaways of the chapter, or added a term to the glossary.
Please have a look when you have time :)