Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to the 2. chapter: "Single-cell RNA sequencing"! #329

Merged
merged 16 commits into from
Feb 20, 2025

Conversation

LuisHeinzlmeier
Copy link
Collaborator

@LuisHeinzlmeier LuisHeinzlmeier commented Feb 4, 2025

I cleaned the sentences (e.g., improved grammar, wording, small typing errors, etc. ) and added features like a note for sequencing length, the key takeaways of the chapter, or added a term to the glossary.

Please have a look when you have time :)

@LuisHeinzlmeier LuisHeinzlmeier changed the title Feature/sc rna seq updates Changes to the 2. chapter: "Single-cell RNA sequencing"! Feb 6, 2025
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! A lot of fixes.

Have you already looked into content updates (new assays, removing unneeded text here, ...) or do you plan to make a follow up PR here?

Cells form open systems which maintain homeostasis, have a metabolism, grow, adapt to their environment, reproduce, respond to stimuli, and organize themselves.
Therefore, cells are the fundamental building block of life which were first discovered in 1665 by the British scientist Robert Hooke. Hooke investigated a thin slice of cork with a very rudimentary microscope, and to his surprise noticed that the slice appeared to resemble a honeycomb. He named these tiny units 'cells'.
Therefore, cells are the fundamental building blocks of life, and they were first discovered in 1665 by the British scientist Robert Hooke.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether we can actually drop all of this fluff although it's kinda cute

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean just the first paragraph with Robert Hooke? Then, I would keep it. It's cute enough and the content will become more complicated anyway. So it's an easy introduction at the beginning.

Do you mean the whole "2.1 The building block of life" part? We could discuss making it shorter in general.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda both. So let's keep the first one an if you have ideas to make the second one shorter, I'm happy to see them implemented. But not a big deal.

@Zethson Zethson requested a review from seohyonkim February 6, 2025 15:16
@LuisHeinzlmeier
Copy link
Collaborator Author

Great! A lot of fixes.

Have you already looked into content updates (new assays, removing unneeded text here, ...) or do you plan to make a follow up PR here?

No, I haven´t added new content yet. I can create a new follow-up branch or push current changes to this PR. Since I don't have much experience using Git Hub on larger projects, perhaps you can recommend one of these options.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Feb 15, 2025

PR Preview Action v1.6.0

🧬 View preview of single-cell best practices at
https://theislab.github.io/single-cell-best-practices/pr-preview/pr-329/

Built to branch gh-pages at 2025-02-20 13:10 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These key takeaway boxes are a really really nice idea. Two comments:

  1. They seem to be a bit/long/verbose. Is there a way to make them shorter or take less space?
  2. We need to agree on a final design of these together with @seohyonkim so that we can roll them out in all chapters.

I solved some merge conflicts.
You can make a follow up PR then additional content improvements. It's good if we keep one PR with one concern.

@LuisHeinzlmeier
Copy link
Collaborator Author

I added a see also dropdown for further readings, many terms, and the new box for key takeaways. The chapter should be ready now! 🚀

@Zethson
Copy link
Member

Zethson commented Feb 20, 2025

I love the see also. I think we could make the strengths and weaknesses maybe look nicer but it's fine. Let's merge this and then iterate.

@Zethson Zethson merged commit 8dc12b2 into main Feb 20, 2025
38 checks passed
@LuisHeinzlmeier
Copy link
Collaborator Author

LuisHeinzlmeier commented Feb 20, 2025

I think we could make the strengths and weaknesses maybe look nicer but it's fine.

This is a good idea. I will keep that in mind for the next iteration! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants