Skip to content

[feat] oauth 로그인 scope 표시 스타일 변경#188

Merged
LeeSangHyeok0731 merged 5 commits into
developfrom
feat/oauth-scope-redesign
Jun 29, 2026
Merged

[feat] oauth 로그인 scope 표시 스타일 변경#188
LeeSangHyeok0731 merged 5 commits into
developfrom
feat/oauth-scope-redesign

Conversation

@LeeSangHyeok0731

Copy link
Copy Markdown
Member

개요 💡

oauth 로그인 scope 표시 스타일 변경하였습니다.

작업내용 ⌨️

  • 권한 텍스트에서 권한에 밑줄 제거
  • scope 표기시 text간 일정한 gap 추가

스크린샷/동영상 📸

image image

@LeeSangHyeok0731 LeeSangHyeok0731 self-assigned this Jun 29, 2026
@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
datagsm-front-admin Ready Ready Preview, Comment Jun 29, 2026 6:44am
datagsm-front-client Ready Ready Preview, Comment Jun 29, 2026 6:44am
datagsm-front-docs Ready Ready Preview, Comment Jun 29, 2026 6:44am
datagsm-front-oauth Ready Ready Preview, Comment Jun 29, 2026 6:44am
datagsm-front-status Ready Ready Preview, Comment Jun 29, 2026 6:44am

Request Review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the styling and layout of the SignInForm component, specifically updating the service name text styles and adjusting the alignment of the application name and description. The review feedback highlights two valid issues: a missing 'group' class on the parent element which prevents the 'group-hover' utility from working, and a Korean spacing typo ('권한 을' instead of '권한을').

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/shared/src/ui/SignInForm/index.tsx
Comment thread packages/shared/src/ui/SignInForm/index.tsx Outdated
@LeeSangHyeok0731 LeeSangHyeok0731 merged commit 25dd08b into develop Jun 29, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants