Skip to content

Revert "Revert "[fix] 어드민 로그인 시 localhost:3001로 이동되는 문제 수정""#421

Merged
junjuny0227 merged 1 commit into
developfrom
revert-420-revert-419-fix/admin-login-redirect
Jun 21, 2026
Merged

Revert "Revert "[fix] 어드민 로그인 시 localhost:3001로 이동되는 문제 수정""#421
junjuny0227 merged 1 commit into
developfrom
revert-420-revert-419-fix/admin-login-redirect

Conversation

@junjuny0227

Copy link
Copy Markdown
Member

Reverts #420

@vercel

vercel Bot commented Jun 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hellogsm-client-26 Building Building Preview, Comment Jun 21, 2026 2:49pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
hellogsm-client-26-admin Skipped Skipped Jun 21, 2026 2:49pm

Request Review

@junjuny0227 junjuny0227 merged commit 319e3a6 into develop Jun 21, 2026
2 of 3 checks passed
@junjuny0227 junjuny0227 deleted the revert-420-revert-419-fix/admin-login-redirect branch June 21, 2026 14:49

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the server-side redirection logic in apps/client/src/app/page.tsx with a client-side redirection component, AdminRedirect.tsx, which uses window.location.replace to navigate to the appropriate admin URL based on the origin. Feedback was provided on AdminRedirect.tsx regarding the usage of the cn utility function, suggesting that static classes should be passed as a single space-separated string rather than multiple comma-separated arguments to improve readability and avoid unnecessary argument parsing.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +19 to +21
<div className={cn('flex', 'h-[calc(100vh-4.625rem)]', 'items-center', 'justify-center')}>
<div className={cn('text-lg', 'font-medium')}>이동 중...</div>
</div>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

cn 함수를 사용할 때 정적 클래스 목록을 쉼표(,)로 구분된 여러 개의 문자열 인자로 전달하고 있습니다. 이는 가독성을 떨어뜨리고 불필요한 인자 파싱을 유발합니다.

단일 공백으로 구분된 하나의 문자열로 합쳐서 전달하는 것이 더 깔끔하고 일반적인 컨벤션에 부합합니다. 정적 클래스 목록이라도 cn 유틸리티 함수를 사용하는 팀의 컨벤션을 유지하면서 인자 전달 방식을 개선해 주세요.

Suggested change
<div className={cn('flex', 'h-[calc(100vh-4.625rem)]', 'items-center', 'justify-center')}>
<div className={cn('text-lg', 'font-medium')}>이동 중...</div>
</div>
<div className={cn('flex h-[calc(100vh-4.625rem)] items-center justify-center')}>
<div className={cn('text-lg font-medium')}>이동 중...</div>
</div>
References
  1. Follow team conventions regarding the use of classname utility functions (like cn), even for static class lists where conditional merging is not strictly required.

junjuny0227 added a commit that referenced this pull request Jun 21, 2026
…-419-fix/admin-login-redirect"

This reverts commit 319e3a6, reversing
changes made to 2199368.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant