Revert "Revert "[fix] 어드민 로그인 시 localhost:3001로 이동되는 문제 수정""#421
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Code Review
This pull request replaces the server-side redirection logic in apps/client/src/app/page.tsx with a client-side redirection component, AdminRedirect.tsx, which uses window.location.replace to navigate to the appropriate admin URL based on the origin. Feedback was provided on AdminRedirect.tsx regarding the usage of the cn utility function, suggesting that static classes should be passed as a single space-separated string rather than multiple comma-separated arguments to improve readability and avoid unnecessary argument parsing.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| <div className={cn('flex', 'h-[calc(100vh-4.625rem)]', 'items-center', 'justify-center')}> | ||
| <div className={cn('text-lg', 'font-medium')}>이동 중...</div> | ||
| </div> |
There was a problem hiding this comment.
cn 함수를 사용할 때 정적 클래스 목록을 쉼표(,)로 구분된 여러 개의 문자열 인자로 전달하고 있습니다. 이는 가독성을 떨어뜨리고 불필요한 인자 파싱을 유발합니다.
단일 공백으로 구분된 하나의 문자열로 합쳐서 전달하는 것이 더 깔끔하고 일반적인 컨벤션에 부합합니다. 정적 클래스 목록이라도 cn 유틸리티 함수를 사용하는 팀의 컨벤션을 유지하면서 인자 전달 방식을 개선해 주세요.
| <div className={cn('flex', 'h-[calc(100vh-4.625rem)]', 'items-center', 'justify-center')}> | |
| <div className={cn('text-lg', 'font-medium')}>이동 중...</div> | |
| </div> | |
| <div className={cn('flex h-[calc(100vh-4.625rem)] items-center justify-center')}> | |
| <div className={cn('text-lg font-medium')}>이동 중...</div> | |
| </div> |
References
- Follow team conventions regarding the use of classname utility functions (like
cn), even for static class lists where conditional merging is not strictly required.
Reverts #420