Skip to content

v20260625.0#97

Merged
hongjm0912 merged 5 commits into
masterfrom
develop
Jun 25, 2026
Merged

v20260625.0#97
hongjm0912 merged 5 commits into
masterfrom
develop

Conversation

@hongjm0912

Copy link
Copy Markdown
Collaborator

#96 의 내용을 master 브랜치에 머지합니다.

- @order(1) → LOWEST_PRECEDENCE 로 변경, ExpectedException 핸들러 명시적 추가
- ThreadPoolExecutor에 DiscardPolicy 설정으로 큐 초과 시 사용자 응답 보호
- Discord Embed 4000자 초과 시 트런케이션 추가

Claude-Session: https://claude.ai/code/session_01PpNw4xQ6zJE2JDwvA8AFYd
…fication

[global] prod 에러 Discord 알림 기능 추가
@hongjm0912 hongjm0912 requested a review from ZaMan0806 June 25, 2026 02:36
@hongjm0912 hongjm0912 self-assigned this Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Discord notification system for reporting server errors, including synchronous and asynchronous exception handlers, a dedicated notification service, and related configuration. The review feedback suggests separating the Discord-specific thread pool executor from the global async executor to prevent task loss and thread name confusion for other async tasks. Additionally, it recommends refining the error message formatting to avoid breaking Markdown syntax when truncating long stack traces.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main/java/team/themoment/readygsmserver/global/config/AsyncConfig.java Outdated
@ZaMan0806 ZaMan0806 changed the title 20260625.0 v20260625.0 Jun 25, 2026
- discordExecutor 전용 Bean으로 분리하여 글로벌 Executor 오염 방지
- @async("discordExecutor")로 Discord 알림에만 전용 스레드풀 적용
- buildDetail() 개별 필드 트런케이션으로 마크다운 포맷 깨짐 방지
- cause == null 방어 코드 추가

Claude-Session: https://claude.ai/code/session_01PpNw4xQ6zJE2JDwvA8AFYd
@hongjm0912 hongjm0912 merged commit 5f6abff into master Jun 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants