Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for PHP 7.4 #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

muhammadn
Copy link

PHP 7.4 ternary operations works differently (ie. more explicit) with brackets.

@muisit
Copy link

muisit commented May 9, 2020

Brackets are inserted wrongly as far as I can see. This seems like a harmful thing to do. Why would you insert closing brackets halfway the ternary operation? Clearly they should be around the whole ternary operator in this visibly formatted expression.

@muhammadn
Copy link
Author

@muisit I'm using PHP 7.4 and trying to fix this issue. If you feel i am wrong, then i hope you can help fix it.

@muisit
Copy link

muisit commented May 9, 2020

As I wrote, the closing parenthesis should be at the end of the expression, not halfway the ternary operator. You have a double closing parenthesis at line 115. Remove one and add it at the very end of that same line (but obviously before the semi-colon...).
Clearly the isset condition check belongs to the expression on that whole line. Where you added the closing parenthesis makes absolutely no sense.

@daaner
Copy link

daaner commented Sep 30, 2020

do you invite PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants