Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking changes for httpsling v0.2.0 #34

Merged
merged 3 commits into from
Sep 4, 2024
Merged

breaking changes for httpsling v0.2.0 #34

merged 3 commits into from
Sep 4, 2024

Conversation

golanglemonade
Copy link
Member

@golanglemonade golanglemonade commented Sep 4, 2024 •
edited
Loading

Updates the httpsling version and addresses all breaking changes. This was tested against both local + production hosts with basic login, graph queries + mutations.

(⎈ |default:default)➜  core git:(httpsling-updates) task cli:login
task: [cli:login:creds] go run main.go login -u [email protected]

Authentication Successful!
auth tokens successfully stored in keychain
(⎈ |default:default)➜  core git:(httpsling-updates) go run cmd/cli/main.go org get    
  ID                          NAME             DESCRIPTION                            PERSONALORG  CHILDREN  MEMBERS  
  01J6X7R91RCAV34CP89RYZB9BY  Absolute Dassie  Personal Organization - Matt Anderson  true         0         1        
  01J6YT7F7ATMENKD40P8EYWQ64  neworg                                                  false        0         0

@golanglemonade golanglemonade changed the title wip: httpsling refactor breaking changes for httpsling v0.2.0 Sep 4, 2024
@golanglemonade
wip: httpsling refactor
dc8c1d8 
Signed-off-by: Sarah Funkhouser <[email protected]>
@golanglemonade
bump httpsling
3169768 
Signed-off-by: Sarah Funkhouser <[email protected]>
@golanglemonade
fix GET requests
9c77dce 
Signed-off-by: Sarah Funkhouser <[email protected]>
@golanglemonade golanglemonade marked this pull request as ready for review September 4, 2024 18:26
@golanglemonade golanglemonade enabled auto-merge (squash) September 4, 2024 18:27
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
19.3% Coverage on New Code (required ≥ 20%)

See analysis details on SonarCloud

@golanglemonade golanglemonade merged commit 5a8f3ae into main Sep 4, 2024
19 of 21 checks passed
@golanglemonade golanglemonade deleted the httpsling-updates branch September 4, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matoszz matoszz matoszz approved these changes

Assignees
No one assigned
Labels
httpserve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@golanglemonade @matoszz