case insensitive for HTML attributes#1096
Open
RobinDev wants to merge 1 commit intothephpleague:2.7from
Open
Conversation
Member
|
Thanks for proposing this change! Would you mind sharing a specific example of the input you're using, and the incorrectly-escaped output? I'd like to include that as a regression test, and also use it to compare how other CommonMark-compliant parsers are handling this. |
colinodell
added
the
not enough info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTML parser treated attribute names in a case-sensitive manner, which is not compliant with the HTML specifications.
This behavior caused incorrect escaping of tags containing attributes with uppercase letters, such as the
viewBoxattribute in SVG tags.This change updates the
PARTIAL_ATTRIBUTENAMEregular expression to accept both uppercase and lowercase letters, ensuring that HTML attributes are correctly recognized regardless of their case.