Allow disabling of inline footnotes + documentation on inline footnotes#1112
Open
chillbram wants to merge 1 commit intothephpleague:mainfrom
Open
Allow disabling of inline footnotes + documentation on inline footnotes#1112chillbram wants to merge 1 commit intothephpleague:mainfrom
chillbram wants to merge 1 commit intothephpleague:mainfrom
Conversation
chillbram
force-pushed
the
anonymous-footnotes
branch
from
70f2416 to
16c49f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: while using our new sup extension, adding a link to superscript (
^[Text](link)^) suddenly created footnotes.I couldn't find any documentation on the
^[Footnote]notation, but diving in the code base I found out this was a feature. So I added the explanation of the feature I found in the test suite and also added some example code to the regular docs.To fix the incompatibility, I propose this new config value
enable_inline_footnotesto allow users to disable inline footnotes. The implementation should be fully backwards compatible, as the default is still set to true. I added a test for this behavior.