Config: Enable safe sampler overrides by default #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Provides safe fallback samplers, intended for better out-of-the-box support for clients that do not pass sampler params
* We provide safe_defaults as a default in config_sample.yml but not internally
This has become a bigger priority with addition of the safe_defaults noob proofing. Signed-off-by: kingbri <[email protected]>
Change the sampling subsection to sampler overrides and add a warning about the default preset. Signed-off-by: kingbri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides safe fallback samplers, intended for better out-of-the-box support for clients that do not pass sampler params.
For example, Cline only passes the sampler param
temperaturewith requests, which results in no tail truncation sampler (i.e. top-p, top-k, min-p, etc.) being applied. This can occasionally lead to sampling of nonsense tokens during generation.