Copy and paste lemmatized text selection in text editor part. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a sentence object and all of its tokens are within a selection, its not necessary to keep the tokens explicitly. If a sentence got among the textmodel objects covered by the selection, but not all of its tokens, then we can not copy the entire sentence.
implement text model element sequence insertion into editor contents more robust and less copy-and-pasty.
…er cursor happens to be a sentence object.
…inkel/bts into 4623-copy_lemmatized_text
for lemmatized copy and paste.
|
TODO: changelog |
…y_lemmatized_text
Conflicts: org.bbaw.bts.ui.commons.corpus/src/org/bbaw/bts/ui/commons/corpus/events/BTSTextSelectionEvent.java org.bbaw.bts.ui.corpus.egy/src/org/bbaw/bts/ui/egy/parts/EgyTextEditorPart.java
Partially selected objects will no longer be included. This may be slightly inconvenient in some cases, but is necessary to make comments work on ambivalences. Otherwise, every selection inside an ambivalence would also include the ambivalence itself.
...when creating comments or highlighting relevant comments in the sidebar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feature 'copy with lemmata', i.e. copy and paste tokenized text, is pretty buggy in general.
Related redmine tickets
Proposed Fix
rewrite the entire copy-and-paste logic.
most significant commits for merge