-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sof-glkda7219max: initial import #7
Conversation
This probably doesn't work as is, but we should compare with Chrome and upstream this. Signed-off-by: Pierre-Louis Bossart <[email protected]>
I can take a look at these UCM changes once I am back from Lyon next week, we likely have some fields that may need updating. The upstreaming effort is definitely appreciated. |
Here is the diff The only thing that really stands out to me is the removal of the HDMI code and the fact that the Spk switch is inverted.
|
@cujomalainey This is a very old UCM and at the time HDMI was not even functional. we should re-add it. |
All our HiFi.conf files should be in either Note for glkda7219 we have both a 1mic and 2mic variant plus a bunch of other board specific variant UCMs. Also are you wanted to the do the glkrt5682 UCMs as well? |
replaced by PR #26 |
This probably doesn't work as is, but we should compare with Chrome
and upstream this.
Signed-off-by: Pierre-Louis Bossart [email protected]