hijack.sh: don't start a second logger in the exit handler #386
Conversation
... because it makes no sense.
When a test using the logger fails it produces a confusing error
message like this:
2020-09-18 10:17:25 UTC [REMOTE_INFO] Starting /usr/bin/sof-logger
-l /etc/sof/sof-byt.ldc -o
/home/ubuntu/sof-test/logs/check-alsabat/<date>/etrace.txt
error: in logger_read(), fread(..., /sys/kernel/debug/sof/etrace)
failed: Inappropriate ioctl for device(25)
Reported by Pierre in #384
This mistake seems to have been there since the dawn of time however no
one noticed because most things logger-related (and others) have been
silenced so far - which is changing now with thesofproject#297.
The problem this fixes can be reproduced trivially with this one-line
patch:
--- a/case-lib/lib.sh
+++ b/case-lib/lib.sh
@@ -125,6 +125,7 @@ func_lib_start_log_collect()
dlogi "Starting $loggerCmd"
# Cleaned up by func_exit_handler() in hijack.sh
sudo "$loggerCmd" &
+ exit 1
}
Signed-off-by: Marc Herbert <[email protected]>
| [[ $exit_status -eq 1 ]] && { | ||
| func_lib_start_log_collect 1 | ||
| sleep 1s | ||
| } |
There was a problem hiding this comment.
@marc-hb Not sure about this. This is not the normal logger run, but capture the separate etrace log in case of output (etrace.txt). Is this already covered somewhere else?
There was a problem hiding this comment.
Thanks @kv2019i for the catch, really appreciated. I've been looking for information about the difference between debug/trace and debug/etrace but didn't find much, any good reference? @ktrzcinx ? I didn't expect both could be used simultaneously, in fact I now realize this PR is (was) an attempt to avoid a failure to use both simultaneously.
There was a problem hiding this comment.
Found something here: thesofproject/sof#3265 (comment)
thanks a lot for your information about traces. This is the kind of information we need to write it in sof-docs.
... because it makes no sense.
When a test using the logger fails it produces a confusing error
message like this:
Reported by Pierre in #384
This mistake seems to have been there since the dawn of time however no
one noticed because most things logger-related (and others) have been
silenced so far - which is changing now with #297.
The problem this fixes can be reproduced trivially with this one-line
patch:
Signed-off-by: Marc Herbert [email protected]