lib.sh: fix recent check_error_in_file() . Exclude BSW #946
Conversation
Add bsw next to byt and bdw. BSW has a regular: ERROR dtrace_add_event(): number of dropped logs = 8 ... too, see Intel daily test 14304 and before. No time to spend on BSW errors that have always been there. Signed-off-by: Marc Herbert <[email protected]>
Use -w to catch the words 'ERR' and 'ERROR' and avoid unrelated words like 'ovERRuns' (unless of course they're prefixed with ERROR) Fixes recent commit 87aeb4d ("check-sof-logger: catch ERROR in firmware traces and fail") Add -i: no reason to catch errors only in upper case. Log the grep commands using set -x Signed-off-by: Marc Herbert <[email protected]>
|
A very strange ... on one device in https://sof-ci.01.org/softestpr/PR946/build114/devicetest while Not caused by this PR. + 2 unrelated suspend/resume failures |
|
SOFCI TEST |
|
https://sof-ci.01.org/softestpr/PR946/build115/devicetest/?model=ADLP_RVP_NOCODEC_IPC4&testcase=check-sof-logger has the same missing |
|
Is the search case sensitive? |
| # -B 2 shows the header line when the first etrace message is an ERROR | ||
| # -A 1 shows whether the ERROR is last or not. | ||
| if (set -x | ||
| grep -B 2 -A 1 -i -w -e 'ERR' -e 'ERROR' "$1" |
There was a problem hiding this comment.
Is it weird that I find "-B2 -A1" more legible?
|
SOFCI TEST |
|
Unrelated error is gone in https://sof-ci.01.org/softestpr/PR946/build119/devicetest, maybe thanks to thesofproject/sof#5027 suspend/resume TIMEOUT https://sof-ci.01.org/softestpr/PR946/build119/devicetest/?model=WHL_UPEXT_HDA_ZEPHYR&testcase=check-suspend-resume-with-capture-5 is unrelated. Everything else green |
2 commits. Main one:
Use -w to catch the words 'ERR' and 'ERROR' and avoid unrelated words
like 'ovERRuns' (unless of course they're prefixed with ERROR)
Fixes recent commit 87aeb4d ("check-sof-logger: catch ERROR in
firmware traces and fail")
Add -i: no reason to catch errors only in upper case.
Log the grep commands using set -x