Conversation
Add support to recognize signed firmware images for Intel Nova Lake. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
September 17, 2026 10:03
Collaborator
Author
|
FYI @lgirdwood @abonislawski , tested with thesofproject/sof-bin#209 |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Production key fingerprint changes warrant final human verification.
Pull request overview
Adds Intel Nova Lake (NVL/NVL-S) production key fingerprints for recognizing signed firmware images.
Changes:
- Adds NVL and NVL-S production key constants.
- Registers both keys in
KNOWN_KEYS.
File summaries
| File | Description |
|---|---|
tools/sof_ri_info/sof_ri_info.py |
Adds and registers Nova Lake key fingerprints. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support to recognize signed firmware images for Intel Nova Lake.