Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topology2: mtl: Add HDMI-in capture support for SSP-based no-headset … #8784

Merged
merged 3 commits into from
Jan 29, 2024
Merged

topology2: mtl: Add HDMI-in capture support for SSP-based no-headset … #8784

merged 3 commits into from
Jan 29, 2024

Conversation

CBala21
Copy link
Contributor

@CBala21 CBala21 commented Jan 24, 2024

…codec products.

Adding support for the product which doesn't have no ssp-based audio codec but need to support HDMI audio playback and HDMI-in capture via I2S.

@CBala21 CBala21 mentioned this pull request Jan 24, 2024
Closed
lgirdwood
lgirdwood reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CBala21 I guess this is a HW I2S/HDMI bridge ? - if so, do we need to spell out this as a special case in more inline comments. Thinking aloud, I would not want anyone to copy this example for native HDMI or native I2S as it could cause confusion ?

@CBala21
Copy link
Contributor Author

CBala21 commented Jan 24, 2024

@CBala21 I guess this is a HW I2S/HDMI bridge ? - if so, do we need to spell out this as a special case in more inline comments. Thinking aloud, I would not want anyone to copy this example for native HDMI or native I2S as it could cause confusion ?

Its not HDMI bridge(converter chip will convert and send samples to I2S pins), for intel soc its just a input to I2S pins and similar as BT offload use case where we get audio samples via I2S pins. So we will handle only SSP configuration in slave mode.

The changes are added to generate the topology configuration for the product which doesn't have I2S audio codec but they need HDMI-In audio capture via I2S interface.

@CBala21
topology2: mtl: Add headset codec macro
c6f380f 
Adding HEADSET_CODEC macro and guarded the SSP configuration handling
under this macro.By this changes we can generate the topology
configuration for the products which has no headset codec.

Signed-off-by: Balamurugan C <[email protected]>
@CBala21
topology2: mtl: Override default HDMI DAI link id's
665c2eb 
override the default HDMI DAI link id's by using make
define parameters instead of fixed in file.

Signed-off-by: Balamurugan C <[email protected]>
@CBala21
topology2: mtl: Generate topology for No headset codec
953d749 
Adding make file changes to generate the topology file for the products
which doesn't have no ssp-based audio codec but need to support
HDMI audio playback and HDMI-in capture via I2S.

Signed-off-by: Balamurugan C <[email protected]>
@CBala21 CBala21 force-pushed the mtl-NoHeadsetcodec+HDMI-In branch from 0db4292 to 953d749 Compare January 25, 2024 07:44
@lgirdwood
Copy link
Member

@plbossart any comments ?

@kv2019i kv2019i merged commit 7002215 into thesofproject:main Jan 29, 2024
39 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbossart plbossart plbossart approved these changes

@bardliao bardliao bardliao approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner

@jsarha jsarha Awaiting requested review from jsarha jsarha is a code owner

@kv2019i kv2019i Awaiting requested review from kv2019i

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CBala21 @lgirdwood @plbossart @bardliao @kv2019i