Topology[DONT REVIEW]: add eq and drc to mtl platform #8788
Conversation
Adding eq and drc to mtl platform for testing. Signed-off-by: Baofeng Tian <[email protected]>
| @@ -66,6 +66,21 @@ PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-hda-efx-generic-4ch.bin,\ | |||
| EFX_FIR_PARAMS=passthrough,EFX_IIR_PARAMS=passthrough,\ | |||
| EFX_DRC_PARAMS=passthrough" | |||
|
|
|||
| # EFX topology for MTL | |||
| "sof-hda-generic\;sof-mtl-hda-efx-generic\;PLATFORM=mtl,HDA_CONFIG=efx,\ | |||
| EFX_FIR_PARAMS=passthrough,EFX_IIR_PARAMS=passthrough,EFX_DRC_PARAMS=passthrough" | |||
There was a problem hiding this comment.
There's already topology sof-hda-efx-generic.tplg that should work for all platforms so this new sof-mtl-hda-efx-generic.tplg is not needed.
When there is no DMIC or I2S the NHLT blob that is platform specific, is not needed. Also we should be able to leave even in NUM_DMICS=2 and NUM_DMICS=4 case the NHLT settings out if we assume the PC BIOS contains usable blob.
This might not be true in FPGA or early RVP platforms so we may need the NHLT versions. Maybe could try if the existing sof-hda-efx-generic-2/4ch.tplg are working with MTL too.
@ujfalusi Please chime in if need if this is not correct.
| EFX_FIR_PARAMS=passthrough,EFX_IIR_PARAMS=passthrough,EFX_DRC_PARAMS=passthrough" | ||
|
|
||
| "sof-hda-generic\;sof-mtl-hda-efx-generic-2ch\;PLATFORM=mtl,\ | ||
| HDA_CONFIG=efx,NUM_DMICS=2,PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-hda-fir-generic-2ch.bin,\ |
There was a problem hiding this comment.
If there's a NHLT_BIN, I think it should have the same name as built .tplg -> .bin to avoid any concurrent build hazards. But it could be that these 2ch and 4ch topologies for MTL are not needed at all.
If the latter confirmed by @ujfalusi , you could instead change this PR to add the components to normal hda-generic topologies to get EQs and DRC fully tested by CI.
Adding eq and drc to mtl platform for testing.